Remove usage of deprecated functions AppendToPath and ToWStringHack in importer_unittest.cc

chrome/browser/importer/importer_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 340 matching lines @@
     HRESULT res = pstore->WriteItem(0, type, subtype, items[i].name,
         items[i].data_size, reinterpret_cast<BYTE*>(items[i].data),
         NULL, 0, 0);
     ASSERT_TRUE(res == PST_E_OK);
   }
 }
 
 TEST_F(ImporterTest, IEImporter) {
   // Sets up a favorites folder.
   app::win::ScopedCOMInitializer com_init;
-  std::wstring path = test_path_.ToWStringHack();
-  file_util::AppendToPath(&path, L"Favorites");
+  FilePath file_path = test_path_.AppendASCII("Favorites");
+  std::wstring path = file_path.value();

[evanm, 2011/01/07 22:46:01]

Can do it on one line:
std::wstring path = test_path_.AppendASCII("Favorites").value();

[tfarina, 2011/01/07 22:50:00]

Done.

   CreateDirectory(path.c_str(), NULL);
   CreateDirectory((path + L"\\SubFolder").c_str(), NULL);
   CreateDirectory((path + L"\\Links").c_str(), NULL);
   CreateDirectory((path + L"\\Links\\SubFolderOfLinks").c_str(), NULL);
   CreateDirectory((path + L"\\\x0061").c_str(), NULL);
   ASSERT_TRUE(CreateUrlFile(path + L"\\Google Home Page.url",
                             L"http://www.google.com/"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\SubFolder\\Title.url",
                             L"http://www.link.com/"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\TheLink.url",
                             L"http://www.links-thelink.com/"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\WithPortAndQuery.url",
                             L"http://host:8080/cgi?q=query"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\\x0061\\\x4E2D\x6587.url",
                             L"http://chinese-title-favorite/"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\Links\\TheLink.url",
                             L"http://www.links-thelink.com/"));
   ASSERT_TRUE(CreateUrlFile(path + L"\\Links\\SubFolderOfLinks\\SubLink.url",
                             L"http://www.links-sublink.com/"));
   file_util::WriteFile(path + L"\\InvalidUrlFile.url", "x", 1);

[evanm, 2011/01/07 22:46:01]

I wonder if we'll need to change more of this file once we change ::WriteFile to
only accept FilePath too.

[tfarina, 2011/01/07 22:50:00]

I'm scared about this, and I'd prefer to let more experienced programmers to do
the changes needed. 

   file_util::WriteFile(path + L"\\PlainTextFile.txt", "x", 1);
 
   // Sets up dummy password data.
   HRESULT res;
 #if 0  // This part of the test is disabled. See bug #2466
   ScopedComPtr<IPStore> pstore;
   HMODULE pstorec_dll;
   GUID type = IEImporter::kUnittestGUID;
   GUID subtype = IEImporter::kUnittestGUID;
   // PStore is read-only in Windows Vista.
@@ skipping 495 matching lines @@
                         true);
 }
 
 TEST_F(ImporterTest, MAYBE(Firefox35Importer)) {
   bool import_search_engines = false;
   scoped_refptr<Firefox3Observer> observer(
       new Firefox3Observer(import_search_engines));
   Firefox3xImporterTest("firefox35_profile", observer.get(), observer.get(),
                         import_search_engines);
 }