Issue 6133006: Enable speech input by default and remove unused code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6133006: Enable speech input by default and remove unused code. (Closed)

Created:
9 years, 11 months ago by Satish

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable speech input by default and remove unused code. BUG=61677 TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70896

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -82 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		3 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/speech/speech_input_browsertest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/speech/speech_input_dispatcher_host.cc	View		1 chunk	+12 lines, -23 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.cc	View		2 chunks	+0 lines, -21 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_thread.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View		3 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Satish

Should I also remove the "ViewMsg_SpeechInput_SetFeatureEnabled" IPC definition from render_messages_internal.h ?

9 years, 11 months ago (2011-01-10 11:07:31 UTC) #1

jorlow

9 years, 11 months ago (2011-01-10 11:49:07 UTC) #2

On 2011/01/10 11:07:31, Satish wrote:
> Should I also remove the "ViewMsg_SpeechInput_SetFeatureEnabled" IPC
definition
> from render_messages_internal.h ?

Yes, please do.  LGTM

Expand Messages | Collapse Messages