Issue 6127001: Geolocation code cleanup following switch to client-based Geolocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6127001: Geolocation code cleanup following switch to client-based Geolocation. (Closed)

Created:
9 years, 11 months ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Geolocation code cleanup following switch to client-based Geolocation. Remove unnecessary methods GeolocationPermissionContext::StartUpdatingRequested and GeolocationPermissionContext::StopUpdatingRequested Remove the unused bridge_id from IPC messages ViewHostMsg_Geolocation_StartUpdating ViewHostMsg_Geolocation_StopUpdating. Remove unnecessary / unused IPC messages: ViewHostMsg_Geolocation_RegisterDispatcher ViewHostMsg_Geolocation_UnregisterDispatcher ViewHostMsg_Geolocation_Suspend ViewHostMsg_Geolocation_Resume Rename GeolocationDispatcherHost::bridge_update_options_ to renderer_update_options, and simplify map type to key only on render id, since there is no relevant bridge id. BUG=59907 TEST=Existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70734

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -142 lines)			Patch
M	chrome/browser/geolocation/geolocation_dispatcher_host.cc	View	1	7 chunks	+19 lines, -69 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	2 chunks	+5 lines, -34 lines	0 comments	Download
M	chrome/renderer/geolocation_dispatcher.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bulach

9 years, 11 months ago (2011-01-06 18:29:38 UTC) #2

LGTM

nice clean up! just a couple of nits:

http://codereview.chromium.org/6127001/diff/1/chrome/browser/geolocation/geol...
File chrome/browser/geolocation/geolocation_dispatcher_host.cc (right):

http://codereview.chromium.org/6127001/diff/1/chrome/browser/geolocation/geol...
chrome/browser/geolocation/geolocation_dispatcher_host.cc:151: // case (location
lookup happens in parallel with the permission request).
nit: I think this whole comment is obsolete now? you can also remove the DCHECK
on 152 as it's now in 145..
you may want to move the DVLOG to 146 as well, so all DCHECKING / DVLOG are done
before the real code..

http://codereview.chromium.org/6127001/diff/1/chrome/browser/geolocation/geol...
chrome/browser/geolocation/geolocation_dispatcher_host.cc:167: DCHECK_EQ(1u,
geolocation_renderer_ids_.count(render_view_id));
nit: s/1u/1U/

Expand Messages | Collapse Messages