Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.cc

Issue 6127001: Geolocation code cleanup following switch to client-based Geolocation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_permission_context.cc
diff --git a/chrome/browser/geolocation/geolocation_permission_context.cc b/chrome/browser/geolocation/geolocation_permission_context.cc
index cd2d0c7830849e900804d9fa1c320f5a59d45dc6..76bc3d7925323bdd55dcbb397b484e6481e0a1b4 100644
--- a/chrome/browser/geolocation/geolocation_permission_context.cc
+++ b/chrome/browser/geolocation/geolocation_permission_context.cc
@@ -432,23 +432,6 @@ void GeolocationPermissionContext::CancelGeolocationPermissionRequest(
CancelPendingInfoBarRequest(render_process_id, render_view_id, bridge_id);
}
-void GeolocationPermissionContext::StartUpdatingRequested(
- int render_process_id, int render_view_id, int bridge_id,
- const GURL& requesting_frame) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- // Note we cannot store the arbitrator as a member as it is not thread safe.
- GeolocationProvider* provider = GeolocationProvider::GetInstance();
-
- // Client-based Geolocation uses a preemptive permission model, so permission
- // ought to have been requested and granted before the controller requests
- // the client to start updating.
- DCHECK(provider->HasPermissionBeenGranted());
-}
-
-void GeolocationPermissionContext::StopUpdatingRequested(
- int render_process_id, int render_view_id, int bridge_id) {
-}
-
void GeolocationPermissionContext::NotifyPermissionSet(
int render_process_id, int render_view_id, int bridge_id,
const GURL& requesting_frame, bool allowed) {
« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698