Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6126002: Remove base/scoped_handle_win.h stub and fix up all callers to use the new location and namespace. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, vrk (LEFT CHROMIUM), cbentzel+watch_chromium.org, sjl, Alpha Left Google, ddorwin+watch_chromium.org, amit, Paweł Hajdan Jr., jam, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, brettw-cc_chromium.org, pam+watch_chromium.org, scherkus (not reviewing), ceee-reviews_chromium.org
Visibility:
Public.

Description

Remove base/scoped_handle_win.h stub and fix up all callers to use the new location and namespace. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70795

Patch Set 1 #

Patch Set 2 : some fixes #

Patch Set 3 : more win fixes #

Patch Set 4 : more win fixes #

Patch Set 5 : linux_view fix #

Total comments: 7

Patch Set 6 : review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -245 lines) Patch
M app/win/win_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/file_util_unittest.cc View 1 2 3 4 5 6 chunks +8 lines, -5 lines 0 comments Download
M base/message_loop_unittest.cc View 7 chunks +16 lines, -14 lines 0 comments Download
M base/message_pump_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_handle.h View 2 chunks +1 line, -5 lines 0 comments Download
D base/scoped_handle_win.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/test/test_file_util_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 2 3 4 5 2 chunks +8 lines, -6 lines 1 comment Download
M base/win/win_util.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ceee/common/process_utils_win.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M ceee/ie/common/chrome_frame_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ceee/ie/plugin/bho/executor_com_unittest.cc View 1 2 3 4 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/ie_importer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 2 3 4 5 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/package_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/utility/utility_thread.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/crash_reporting/minidump_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome_frame/crash_reporting/nt_loader_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome_frame/test/dll_redirector_test.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/test/test_server_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/test/test_with_web_server.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome_frame/test/urlmon_moniker_integration_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/test_utils.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/vtable_patch_manager_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M gfx/icon_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_channel_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/audio/win/wavein_input_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/win/waveout_output_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M net/disk_cache/cache_util_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/test/test_server.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/test/test_server_win.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M printing/emf_win_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/src/file_policy_test.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M sandbox/src/filesystem_policy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/src/process_policy_test.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M sandbox/src/registry_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/restricted_token_utils.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M sandbox/src/sync_policy_test.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M sandbox/src/unload_dll_test.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M sandbox/src/win_utils_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-07 00:41:36 UTC) #1
brettw
LGTM http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc File base/file_util_unittest.cc (right): http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc#newcode14 base/file_util_unittest.cc:14: #include "base/win/scoped_handle.h" This shouldn't go here above the ...
9 years, 11 months ago (2011-01-07 18:03:46 UTC) #2
tfarina
http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc File base/file_util_unittest.cc (right): http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc#newcode14 base/file_util_unittest.cc:14: #include "base/win/scoped_handle.h" On 2011/01/07 18:03:46, brettw wrote: > This ...
9 years, 11 months ago (2011-01-07 20:11:13 UTC) #3
tfarina
http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc File base/file_util_unittest.cc (right): http://codereview.chromium.org/6126002/diff/11001/base/file_util_unittest.cc#newcode14 base/file_util_unittest.cc:14: #include "base/win/scoped_handle.h" On 2011/01/07 18:03:46, brettw wrote: > This ...
9 years, 11 months ago (2011-01-07 22:23:08 UTC) #4
brettw
9 years, 11 months ago (2011-01-07 23:15:10 UTC) #5 
LGTM

http://codereview.chromium.org/6126002/diff/16001/base/win/event_trace_contro...
File base/win/event_trace_controller_unittest.cc (right):

http://codereview.chromium.org/6126002/diff/16001/base/win/event_trace_contro...
base/win/event_trace_controller_unittest.cc:7: #include <initguid.h>  // NOLINT.
Why NOLINT?

Powered by Google App Engine
This is Rietveld 408576698