Make ExtensionBrowserEventRouter owned by ExtensionService....

Make ExtensionBrowserEventRouter owned by ExtensionService.

Before this change, it's a Singleton that gets passed a pointer to a Profile
during Init(), and holds onto that pointer even after the Profile gets 
destroyed. With this change, it's owned by ExtensionService and is destroyed
when the profile is being destructed.

BUG=67927
TEST=On linux, run 'browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager --gtest_repeat=100 --gtest_break_on_failure'. Before this CL, you'll occasionally get a failure because of the race condition described above.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71526

[asargent_no_longer_on_chrome, 2011-01-10 23:14:34]

To review this, I'd suggest starting with extension_service.{h,cc}, then look at
extension_browser_event_router.{h,cc}, then the rest of the files.

Also, I think some of our other extension event routers might benefit from this
same refactoring to prevent similar kinds of bugs during shutdown. I can create
a separate bug for this assuming you agree it's a good approach.

[asargent_no_longer_on_chrome, 2011-01-11 00:57:03]

Oops, I forgot to include a review in the to: line on this CL. That's ok because
I realized it has one or two problems I still need to fix, so please disregard
for now.

[asargent_no_longer_on_chrome, 2011-01-11 18:04:44]

Ok, actually ready for review now. See earlier message for a suggested order to
view the changes in.

[Erik does not do reviews, 2011-01-12 00:31:54]

LGTM

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:8: #include <set>
I don't see anything new that uses this.

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/gtk/location...
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/gtk/location...
chrome/browser/gtk/location_bar_view_gtk.cc:7: #include <algorithm>
why did these get added?

[asargent_no_longer_on_chrome, 2011-01-13 21:34:07]

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service.cc:8: #include <set>
On 2011/01/12 00:31:54, Erik Kay wrote:
> I don't see anything new that uses this.
There's existing code that uses it - I noticed a warning about it missing from
running 'gcl lint' on my CL, and figured I'd fix it while I'm in here.

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/gtk/location...
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/6125003/diff/73001/chrome/browser/gtk/location...
chrome/browser/gtk/location_bar_view_gtk.cc:7: #include <algorithm>
On 2011/01/12 00:31:54, Erik Kay wrote:
> why did these get added?
Same deal here - just cleanup of gcl lint while I'm in the neighborhood.