Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/extensions/page_action_apitest.cc

Issue 6125003: Make ExtensionBrowserEventRouter owned by ExtensionService.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_apitest.cc
===================================================================
--- chrome/browser/extensions/page_action_apitest.cc (revision 71520)
+++ chrome/browser/extensions/page_action_apitest.cc (working copy)
@@ -40,7 +40,8 @@
ResultCatcher catcher;
int tab_id =
ExtensionTabUtil::GetTabId(browser()->GetSelectedTabContents());
- ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
+ ExtensionService* service = browser()->profile()->GetExtensionService();
+ service->browser_event_router()->PageActionExecuted(
browser()->profile(), extension->id(), "", tab_id, "", 0);
EXPECT_TRUE(catcher.GetNextResult());
}
@@ -77,7 +78,8 @@
// install a page action popup.
{
ResultCatcher catcher;
- ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
+ ExtensionService* service = browser()->profile()->GetExtensionService();
+ service->browser_event_router()->PageActionExecuted(
browser()->profile(), extension->id(), "action", tab_id, "", 1);
ASSERT_TRUE(catcher.GetNextResult());
}
@@ -152,7 +154,8 @@
ResultCatcher catcher;
int tab_id =
ExtensionTabUtil::GetTabId(browser()->GetSelectedTabContents());
- ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
+ ExtensionService* service = browser()->profile()->GetExtensionService();
+ service->browser_event_router()->PageActionExecuted(
browser()->profile(), extension->id(), "action", tab_id, "", 1);
EXPECT_TRUE(catcher.GetNextResult());
}
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698