Downgrade a CHECK to a LOG(ERROR) so we don't crash if we

Downgrade a CHECK to a LOG(ERROR) so we don't crash if we
fail to load resources.pak.  This allows us to collect more
UMA stats.

BUG=58056
TEST=Delete resources.pak and start chrome.  It shouldn't crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71117

[Elliot Glaysher, 2011-01-12 00:27:22]

Ok
On Jan 11, 2011 3:30 PM, <tony@chromium.org> wrote:
> Reviewers: Elliot Glaysher, eroman,
>
> Description:
> Downgrade a CHECK to a LOG(ERROR) so we don't crash if we
> fail to load resources.pak.
>
> BUG=58056
> TEST=Delete resources.pak and start chrome. It shouldn't crash.
>
> Please review this at http://codereview.chromium.org/6123006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M app/resource_bundle.cc
>
>
> Index: app/resource_bundle.cc
> diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc
> index
>
b0e79ed93ecfdaded07fcd8aa978b96255c69c0b..93669bc2fcc8ab70bd80cb6606e2d48af9ec00f2

> 100644
> --- a/app/resource_bundle.cc
> +++ b/app/resource_bundle.cc
> @@ -248,7 +248,9 @@ void ResourceBundle::LoadedDataPack::Load() {
> DCHECK(!data_pack_.get());
> data_pack_.reset(new app::DataPack);
> bool success = data_pack_->Load(path_);
> - CHECK(success) << "Failed to load " << path_.value();
> + LOG_IF(ERROR, !success) << "Failed to load " << path_.value()
> + << "\nYou will not be able to use the Bookmarks Manager or "
> + << "about:net-internals.";
> }
>
> bool ResourceBundle::LoadedDataPack::GetStringPiece(
>
>

[eroman, 2011-01-12 00:29:23]

LGTM

On Tue, Jan 11, 2011 at 1:30 PM,  <tony@chromium.org> wrote:
> Reviewers: Elliot Glaysher, eroman,
>
> Description:
> Downgrade a CHECK to a LOG(ERROR) so we don't crash if we
> fail to load resources.pak.
>
> BUG=58056
> TEST=Delete resources.pak and start chrome.  It shouldn't crash.
>
> Please review this at http://codereview.chromium.org/6123006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M app/resource_bundle.cc
>
>
> Index: app/resource_bundle.cc
> diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc
> index
>
b0e79ed93ecfdaded07fcd8aa978b96255c69c0b..93669bc2fcc8ab70bd80cb6606e2d48af9ec00f2
> 100644
> --- a/app/resource_bundle.cc
> +++ b/app/resource_bundle.cc
> @@ -248,7 +248,9 @@ void ResourceBundle::LoadedDataPack::Load() {
>   DCHECK(!data_pack_.get());
>   data_pack_.reset(new app::DataPack);
>   bool success = data_pack_->Load(path_);
> -  CHECK(success) << "Failed to load " << path_.value();
> +  LOG_IF(ERROR, !success) << "Failed to load " << path_.value()
> +      << "\nYou will not be able to use the Bookmarks Manager or "
> +      << "about:net-internals.";
>  }
>
>  bool ResourceBundle::LoadedDataPack::GetStringPiece(
>
>
>