app/resource_bundle.cc - Issue 6123006: Downgrade a CHECK to a LOG(ERROR) so we don't crash if we

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/resource_bundle.cc

Issue 6123006: Downgrade a CHECK to a LOG(ERROR) so we don't crash if we (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: app/resource_bundle.cc

diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc

index b0e79ed93ecfdaded07fcd8aa978b96255c69c0b..93669bc2fcc8ab70bd80cb6606e2d48af9ec00f2 100644

--- a/app/resource_bundle.cc

+++ b/app/resource_bundle.cc

@@ -248,7 +248,9 @@ void ResourceBundle::LoadedDataPack::Load() {

DCHECK(!data_pack_.get());

data_pack_.reset(new app::DataPack);

bool success = data_pack_->Load(path_);

- CHECK(success) << "Failed to load " << path_.value();

+ LOG_IF(ERROR, !success) << "Failed to load " << path_.value()

+ << "\nYou will not be able to use the Bookmarks Manager or "

+ << "about:net-internals.";

}

bool ResourceBundle::LoadedDataPack::GetStringPiece(

« no previous file with comments | « no previous file | no next file » | no next file with comments »