views textfield: Handle ctrl and shift modifiers for Backspace and Delete

views textfield: Handle ctrl and shift modifiers for Backspace and Delete

BUG=none
TEST=NativeTextfieldViewsTest.InsertionDeletionTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71041

[oshima, 2011-01-10 23:15:17]

http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views.cc:476: }
are we going to implement gtk behavior? If so, ctrl back removes the work even
if the text is selected.
(and shift-control-back does remove to the begining even with selection) are you
going to fix this too?

[sadrul, 2011-01-11 04:46:54]

http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views.cc:476: }
On 2011/01/10 23:15:17, oshima wrote:
> are we going to implement gtk behavior? If so, ctrl back removes the work even
> if the text is selected.
> (and shift-control-back does remove to the begining even with selection) are
you
> going to fix this too?

I did some testing, out of curiosity, and the behavior seem to be different
across platforms and toolkits. Following is a list of the behaviour of ctrl+bksp
(c-b) and ctrl+shift+bksp (c-s-b) when some text is selected:

linux gtk:
	c-b: erase previous word, keep selection
	c-s-b: erase upto beginning, keep selection

linux webkit:
	c-b: erase selection
	c-s-b: erase selection 

linux firefox:
	c-b:  erase selection
	c-s-b: nothing

windows (gtalk textfield):
	c-b: clear selection, erase previous word
	c-s-b: clear selection, erase previous word

windows webkit:
	c-b: erase selection
	c-s-b: nothing

windows firefox:
	c-b: clear selection, erase previous word
	c-s-b: nothing

I think it makes sense to imitate the behaviour of webkit, since the same
behaviour on views-textfield and webkit-textfield would be easier for users to
get used to (which would mean behaving differently on windows and linux). What
do you think?

I also plan on including similar behaviour for ctrl+Delete and ctrl+shift+Delete
in this CL.

On a somewhat related noted: I was wondering if there are plans to have
undo/redo support in views-textfield (at least for the omnibox, it's probably
something that will be missed if it isn't there)?

[sadrul, 2011-01-11 05:12:50]

> I think it makes sense to imitate the behaviour of webkit, since the same
> behaviour on views-textfield and webkit-textfield would be easier for users to
> get used to (which would mean behaving differently on windows and linux). What
> do you think?

I have made this change in patchset 3.

> I also plan on including similar behaviour for ctrl+Delete and
ctrl+shift+Delete
> in this CL.

I have included this too in patchset 3.

[oshima, 2011-01-11 08:34:58]

LGTM

On Mon, Jan 10, 2011 at 8:46 PM, <sadrul@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
> File views/controls/textfield/native_textfield_views.cc (right):
>
>
>
http://codereview.chromium.org/6119003/diff/2001/views/controls/textfield/nat...
> views/controls/textfield/native_textfield_views.cc:476: }
> On 2011/01/10 23:15:17, oshima wrote:
>
>> are we going to implement gtk behavior? If so, ctrl back removes the
>>
> work even
>
>> if the text is selected.
>> (and shift-control-back does remove to the begining even with
>>
> selection) are you
>
>> going to fix this too?
>>
>
> I did some testing, out of curiosity, and the behavior seem to be
> different across platforms and toolkits. Following is a list of the
> behaviour of ctrl+bksp (c-b) and ctrl+shift+bksp (c-s-b) when some text
> is selected:
>
> linux gtk:
>        c-b: erase previous word, keep selection
>        c-s-b: erase upto beginning, keep selection
>
> linux webkit:
>        c-b: erase selection
>        c-s-b: erase selection
>
> linux firefox:
>        c-b:  erase selection
>        c-s-b: nothing
>
> windows (gtalk textfield):
>        c-b: clear selection, erase previous word
>        c-s-b: clear selection, erase previous word
>
> windows webkit:
>        c-b: erase selection
>        c-s-b: nothing
>
> windows firefox:
>        c-b: clear selection, erase previous word
>        c-s-b: nothing
>
> I think it makes sense to imitate the behaviour of webkit, since the
> same behaviour on views-textfield and webkit-textfield would be easier
> for users to get used to (which would mean behaving differently on
> windows and linux). What do you think?
>

I think this is fine, at least for the time being.

>
> I also plan on including similar behaviour for ctrl+Delete and
> ctrl+shift+Delete in this CL.
>
> On a somewhat related noted: I was wondering if there are plans to have
> undo/redo support in views-textfield (at least for the omnibox, it's
> probably something that will be missed if it isn't there)?



Yes. I thought I had it in the comment, but if not, please add (or I'll
add).

- oshima

>
>
> http://codereview.chromium.org/6119003/
>

[sadrul, 2011-01-11 14:17:03]

On 2011/01/11 08:34:58, oshima wrote:
> LGTM

Thanks for looking at this!

[snip]
> > On a somewhat related noted: I was wondering if there are plans to have
> > undo/redo support in views-textfield (at least for the omnibox, it's
> > probably something that will be missed if it isn't there)?
> 
> Yes. I thought I had it in the comment, but if not, please add (or I'll
> add).

I have added it in the list of not-yet supported features.