views textfield: Handle ctrl and shift modifiers for Backspace and Delete

views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 446 matching lines @@
         break;
       case app::VKEY_END:
         model_->MoveCursorToEnd(selection);
         cursor_changed = true;
         break;
       case app::VKEY_HOME:
         model_->MoveCursorToStart(selection);
         cursor_changed = true;
         break;
       case app::VKEY_BACK:
+        if (!model_->HasSelection()) {
+          if (selection && control) {
+            // If both shift and control are pressed, then erase upto the
+            // beginning of the buffer.
+            model_->MoveCursorToStart(true);
+          } else if (control) {
+            // Otherwise, if control is pressed, then erase the previous word.
+            model_->MoveCursorToPreviousWord(true);
+          }
+        }

[oshima, 2011/01/10 23:15:17]

are we going to implement gtk behavior? If so, ctrl back removes the work even
if the text is selected.
(and shift-control-back does remove to the begining even with selection) are you
going to fix this too?

[sadrul, 2011/01/11 04:46:55]

I did some testing, out of curiosity, and the behavior seem to be different
across platforms and toolkits. Following is a list of the behaviour of ctrl+bksp
(c-b) and ctrl+shift+bksp (c-s-b) when some text is selected:

linux gtk:
	c-b: erase previous word, keep selection
	c-s-b: erase upto beginning, keep selection

linux webkit:
	c-b: erase selection
	c-s-b: erase selection 

linux firefox:
	c-b:  erase selection
	c-s-b: nothing

windows (gtalk textfield):
	c-b: clear selection, erase previous word
	c-s-b: clear selection, erase previous word

windows webkit:
	c-b: erase selection
	c-s-b: nothing

windows firefox:
	c-b: clear selection, erase previous word
	c-s-b: nothing

I think it makes sense to imitate the behaviour of webkit, since the same
behaviour on views-textfield and webkit-textfield would be easier for users to
get used to (which would mean behaving differently on windows and linux). What
do you think?

I also plan on including similar behaviour for ctrl+Delete and ctrl+shift+Delete
in this CL.

On a somewhat related noted: I was wondering if there are plans to have
undo/redo support in views-textfield (at least for the omnibox, it's probably
something that will be missed if it isn't there)?

         text_changed = model_->Backspace();
         cursor_changed = true;
         break;
       case app::VKEY_DELETE:
         text_changed = model_->Delete();
         break;
       case app::VKEY_INSERT:
         insert_ = !insert_;
         cursor_changed = true;
         break;
@@ skipping 237 matching lines @@
 }
 
 void NativeTextfieldViews::TextfieldBorder::SetInsets(int top,
                                                       int left,
                                                       int bottom,
                                                       int right) {
   insets_.Set(top, left, bottom, right);
 }
 
 }  // namespace views