Avoid calling inherited setters when creating object literals and their boilerplates.

Avoid calling inherited setters when creating object literals and their boilerplates.
Fix issue 1015.

Committed: http://code.google.com/p/v8/source/detail?r=6205

[fschneider, 2011-01-06 13:36:23]

LGTM.

Please mention the issue number in the commit message.

http://codereview.chromium.org/6118001/diff/1/src/handles.cc
File src/handles.cc (right):

http://codereview.chromium.org/6118001/diff/1/src/handles.cc#newcode428
src/handles.cc:428: ASSERT(!(object->HasPixelElements() ||
object->HasExternalArrayElements()));
I like to split asserts so that there is only one condition per assert:

ASSERT(!object->HasPixelElements());
ASSERT(!object->HasExternalArrayElements());

http://codereview.chromium.org/6118001/diff/1/src/handles.h
File src/handles.h (right):

http://codereview.chromium.org/6118001/diff/1/src/handles.h#newcode220
src/handles.h:220: Handle<Object> IgnoreAttributesAndSetLocalProperty(
Maybe the name should rather be SetLocalPropertyAndIgnoreAttributes?

[Lasse Reichstein, 2011-01-06 13:55:51]

http://codereview.chromium.org/6118001/diff/1/src/handles.cc
File src/handles.cc (right):

http://codereview.chromium.org/6118001/diff/1/src/handles.cc#newcode428
src/handles.cc:428: ASSERT(!(object->HasPixelElements() ||
object->HasExternalArrayElements()));
On 2011/01/06 13:36:24, fschneider wrote:
> I like to split asserts so that there is only one condition per assert:
> 
> ASSERT(!object->HasPixelElements());
> ASSERT(!object->HasExternalArrayElements());

Done.

http://codereview.chromium.org/6118001/diff/1/src/handles.h
File src/handles.h (right):

http://codereview.chromium.org/6118001/diff/1/src/handles.h#newcode220
src/handles.h:220: Handle<Object> IgnoreAttributesAndSetLocalProperty(
On 2011/01/06 13:36:24, fschneider wrote:
> Maybe the name should rather be SetLocalPropertyAndIgnoreAttributes?

Changed to SetLocalPropertyIgnoreAttributes. Should it be "IgnoringAttributes"?