Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/accessors.cc

Issue 6118001: Avoid calling inherited setters when creating object literals and their boilerplates. (Closed)
Patch Set: Address review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 object = *object_handle; 119 object = *object_handle;
120 value = *value_handle; 120 value = *value_handle;
121 121
122 if (uint32_v->Number() == number_v->Number()) { 122 if (uint32_v->Number() == number_v->Number()) {
123 if (object->IsJSArray()) { 123 if (object->IsJSArray()) {
124 return JSArray::cast(object)->SetElementsLength(*uint32_v); 124 return JSArray::cast(object)->SetElementsLength(*uint32_v);
125 } else { 125 } else {
126 // This means one of the object's prototypes is a JSArray and 126 // This means one of the object's prototypes is a JSArray and
127 // the object does not have a 'length' property. 127 // the object does not have a 'length' property.
128 // Calling SetProperty causes an infinite loop. 128 // Calling SetProperty causes an infinite loop.
129 return object->IgnoreAttributesAndSetLocalProperty(Heap::length_symbol(), 129 return object->SetLocalPropertyIgnoreAttributes(Heap::length_symbol(),
130 value, NONE); 130 value, NONE);
131 } 131 }
132 } 132 }
133 return Top::Throw(*Factory::NewRangeError("invalid_array_length", 133 return Top::Throw(*Factory::NewRangeError("invalid_array_length",
134 HandleVector<Object>(NULL, 0))); 134 HandleVector<Object>(NULL, 0)));
135 } 135 }
136 136
137 137
138 const AccessorDescriptor Accessors::ArrayLength = { 138 const AccessorDescriptor Accessors::ArrayLength = {
139 ArrayGetLength, 139 ArrayGetLength,
140 ArraySetLength, 140 ArraySetLength,
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 } 894 }
895 895
896 896
897 const AccessorDescriptor Accessors::ObjectPrototype = { 897 const AccessorDescriptor Accessors::ObjectPrototype = {
898 ObjectGetPrototype, 898 ObjectGetPrototype,
899 ObjectSetPrototype, 899 ObjectSetPrototype,
900 0 900 0
901 }; 901 };
902 902
903 } } // namespace v8::internal 903 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698