Call CoInitialize before using Win 7 Location API.

Call CoInitialize before using Win 7 Location API.

BUG=66822
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71166

[bulach, 2011-01-11 16:46:49]

LGTM

a few suggestions below, let me know your thoughts:

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
File chrome/browser/geolocation/win7_location_api_win.h (right):

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:25: // Public for testing.
See Create() above for normal usage.
should I rotate my monitor? :)

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:27: void Init(HINSTANCE
prop_library,
actually, perhaps make both the ctor and init private, and have a
"CreateForTests" that would receive these params below?

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:54: // Ensure that COM has
been initialised when we use the class.
s/has been initialized/has been initialized for this thread/

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:55:
app::win::ScopedCOMInitializer com_initializer_;
make this as the first member of this class.

[John Knottenbelt, 2011-01-12 11:16:13]

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
File chrome/browser/geolocation/win7_location_api_win.h (right):

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:25: // Public for testing.
See Create() above for normal usage.
On 2011/01/11 16:46:49, bulach wrote:
> should I rotate my monitor? :)

Done.

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:27: void Init(HINSTANCE
prop_library,
On 2011/01/11 16:46:49, bulach wrote:
> actually, perhaps make both the ctor and init private, and have a
> "CreateForTests" that would receive these params below?

Done.

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:54: // Ensure that COM has
been initialised when we use the class.
On 2011/01/11 16:46:49, bulach wrote:
> s/has been initialized/has been initialized for this thread/

Done.

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:55:
app::win::ScopedCOMInitializer com_initializer_;
On 2011/01/11 16:46:49, bulach wrote:
> make this as the first member of this class.

Done.

http://codereview.chromium.org/6115004/diff/2001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_win.h:55:
app::win::ScopedCOMInitializer com_initializer_;
On 2011/01/11 16:46:49, bulach wrote:
> make this as the first member of this class.

Done.

[bulach, 2011-01-12 11:24:12]

LGTM

http://codereview.chromium.org/6115004/diff/8001/chrome/browser/geolocation/w...
File chrome/browser/geolocation/win7_location_api_unittest_win.cc (right):

http://codereview.chromium.org/6115004/diff/8001/chrome/browser/geolocation/w...
chrome/browser/geolocation/win7_location_api_unittest_win.cc:296: return
Win7LocationApi::CreateForTesting(&MockPropVariantToDoubleFunction, locator);
>80cols