Call CoInitialize before using Win 7 Location API.

chrome/browser/geolocation/win7_location_api_win.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GEOLOCATION_WIN7_LOCATION_API_WIN_H_
 #define CHROME_BROWSER_GEOLOCATION_WIN7_LOCATION_API_WIN_H_
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <locationapi.h>
 #include <sensors.h>
 #include <Windows.h>
 
+#include "app/win/scoped_com_initializer.h"
 #include "base/time.h"
 
 struct Geoposition;
 
 // PropVariantToDouble
 typedef HRESULT (WINAPI* PropVariantToDoubleFunction)
     (REFPROPVARIANT propvarIn, DOUBLE *pdblRet);
 
 class Win7LocationApi {
  public:
-  // Public for testing. See Create() below for normal usage.
-  Win7LocationApi(HINSTANCE prop_library,
-                  PropVariantToDoubleFunction PropVariantToDouble_function,
-                  ILocation* locator);
+  // Public for testing. See Create() above for normal usage.

[bulach, 2011/01/11 16:46:49]

should I rotate my monitor? :)

[John Knottenbelt, 2011/01/12 11:16:13]

Done.

+  Win7LocationApi();
+  void Init(HINSTANCE prop_library,

[bulach, 2011/01/11 16:46:49]

actually, perhaps make both the ctor and init private, and have a
"CreateForTests" that would receive these params below?

[John Knottenbelt, 2011/01/12 11:16:13]

Done.

+            PropVariantToDoubleFunction PropVariantToDouble_function,
+            ILocation* locator);
   virtual ~Win7LocationApi();
-
   // Attempts to load propsys.dll, initialise |location_| and requests the user
   // for access to location information. Creates and returns ownership of an
   // instance of Win7LocationApi if all succeed.
   static Win7LocationApi* Create();
   // Gives the best available position.
   // Returns false if no valid position is available.
   virtual void GetPosition(Geoposition* position);
   // Changes the "accuracy" needed. Affects power levels of devices.
   virtual bool SetHighAccuracy(bool acc);
 
  private:
   // Provides the best position fix if one is available.
   // Does this by requesting a location report and querying it to obtain
   // location information.
   virtual bool GetPositionIfFixed(Geoposition* position);
 
   // ILocation object that lets us communicate with the Location and
   // Sensors platform.
   CComPtr<ILocation> locator_;
   // Holds the opened propsys.dll library that is passed on construction.
   // This class is responsible for closing it.
   HINSTANCE prop_lib_;
   PropVariantToDoubleFunction PropVariantToDouble_function_;
+  // Ensure that COM has been initialised when we use the class.

[bulach, 2011/01/11 16:46:49]

s/has been initialized/has been initialized for this thread/

[John Knottenbelt, 2011/01/12 11:16:13]

Done.

+  app::win::ScopedCOMInitializer com_initializer_;

[bulach, 2011/01/11 16:46:49]

make this as the first member of this class.

[John Knottenbelt, 2011/01/12 11:16:13]

Done.

[John Knottenbelt, 2011/01/12 11:16:13]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(Win7LocationApi);
 };
 
 #endif  // CHROME_BROWSER_GEOLOCATION_WIN7_LOCATION_API_WIN_H_