AU: Function to trigger crash reporter.

AU: Function to trigger crash reporter.

This CL introduces a new utility function that fork()s and has the
child call abort(), thus triggering the crash reporter. The actual
work is done in a main loop callback to ensure that the stack trace is
the same for all calls to this function.

TEST=unittest (minimal), tested on device - saw crash reporter pick up the crash.
BUG=10739
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=712b3ac

[petkov, 2011-01-07 17:39:34]

LGTM w/ some nits.

Once we start using this the crash rate will go up significantly. We should
really plan to fix all these error events.

http://codereview.chromium.org/6114002/diff/1/utils.cc
File utils.cc (right):

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode510
utils.cc:510: if (pid < 0) {
Maybe just CHECK(pid >= 0) and no comment to reduce verbosity.

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode520
utils.cc:520: if (result < 0) {
LOG_IF(ERROR, result < 0) << "..."

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode528
utils.cc:528: g_timeout_add_seconds(0, &TriggerCrashReporterUpload, NULL);
any benefit/drawback to using g_idle_add? probably doesn't matter...

[adlr, 2011-01-07 21:13:42]

thanks for the review. fixed and pushed.

http://codereview.chromium.org/6114002/diff/1/utils.cc
File utils.cc (right):

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode510
utils.cc:510: if (pid < 0) {
On 2011/01/07 17:39:34, petkov wrote:
> Maybe just CHECK(pid >= 0) and no comment to reduce verbosity.
> 

Done.

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode520
utils.cc:520: if (result < 0) {
On 2011/01/07 17:39:34, petkov wrote:
> LOG_IF(ERROR, result < 0) << "..."

Done.

http://codereview.chromium.org/6114002/diff/1/utils.cc#newcode528
utils.cc:528: g_timeout_add_seconds(0, &TriggerCrashReporterUpload, NULL);
On 2011/01/07 17:39:34, petkov wrote:
> any benefit/drawback to using g_idle_add? probably doesn't matter...

good thought. we may as well use that. i put it in.

[adlr, 2011-01-07 21:13:58]

err. will push when tree opens