AU: Function to trigger crash reporter.

utils.cc

 // Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "update_engine/utils.h"
 
 #include <sys/mount.h>
 #include <sys/resource.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <sys/wait.h>
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
 
 #include <algorithm>
 
@@ skipping 473 matching lines @@
   vector<string> command;
   command.push_back("/sbin/shutdown");
   command.push_back("-r");
   command.push_back("now");
   int rc = 0;
   Subprocess::SynchronousExec(command, &rc);
   TEST_AND_RETURN_FALSE(rc == 0);
   return true;
 }
 
+namespace {
+// Do the actual trigger. We do it as a main-loop callback to (try to) get a
+// consistent stack trace.
+gboolean TriggerCrashReporterUpload(void* unused) {
+  pid_t pid = fork();
+  if (pid < 0) {

[petkov, 2011/01/07 17:39:34]

Maybe just CHECK(pid >= 0) and no comment to reduce verbosity.

[adlr, 2011/01/07 21:13:42]

Done.

+    // fork() failed. Something is very wrong.
+    CHECK(false) << "fork failed";
+  }
+  if (pid == 0) {
+    // We are the child. Crash.
+    abort();  // never returns
+  }
+  // We are the parent. Wait for child to terminate.
+  pid_t result = waitpid(pid, NULL, 0);
+  if (result < 0) {

[petkov, 2011/01/07 17:39:34]

LOG_IF(ERROR, result < 0) << "..."

[adlr, 2011/01/07 21:13:42]

Done.

+    LOG(ERROR) << "waitpid() failed";
+  }
+  return FALSE;  // Don't call this callback again
+}
+}  // namespace {}
+
+void ScheduleCrashReporterUpload() {
+  g_timeout_add_seconds(0, &TriggerCrashReporterUpload, NULL);

[petkov, 2011/01/07 17:39:34]

any benefit/drawback to using g_idle_add? probably doesn't matter...

[adlr, 2011/01/07 21:13:42]

good thought. we may as well use that. i put it in.

+}
+
 bool SetProcessPriority(ProcessPriority priority) {
   int prio = static_cast<int>(priority);
   LOG(INFO) << "Setting process priority to " << prio;
   TEST_AND_RETURN_FALSE(setpriority(PRIO_PROCESS, 0, prio) == 0);
   return true;
 }
 
 int ComparePriorities(ProcessPriority priority_lhs,
                       ProcessPriority priority_rhs) {
   return static_cast<int>(priority_rhs) - static_cast<int>(priority_lhs);
 }
 
 int FuzzInt(int value, unsigned int range) {
   int min = value - range / 2;
   int max = value + range - range / 2;
   return base::RandInt(min, max);
 }
 
 const char* const kStatefulPartition = "/mnt/stateful_partition";
 
 }  // namespace utils
 
 }  // namespace chromeos_update_engine