Autofill i18n heuristics regular expressions should include credit cards

Autofill i18n heuristics regular expressions should include credit cards

This change localizes the Autofill heuristics regular expressions pertaining to credit card information.

BUG=55787
TEST=FormStructureBrowserTest.HTMLFiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71089

[jungshik at Google, 2011-01-11 19:52:12]

LGTM !

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
File chrome/test/data/autofill_heuristics/input/form_de.html (right):

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
chrome/test/data/autofill_heuristics/input/form_de.html:4: <meta
http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
Just a thought (it does not matter at all): Perhaps, we just want to use HTML5
doctype and simplify the above meta line to '<meta charset="UTF-8">'. It does
not affect anything at all. It just occurred to me.

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
File chrome/test/data/autofill_heuristics/input/form_en.html (right):

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
chrome/test/data/autofill_heuristics/input/form_en.html:20: <label for="c1">Name
on card:</label> <input type="text" id="c1"><br>
again not related to this CL (sorry for digressing): Do we have a test for other
ways of marking up the input field (other than using 'label' tag)? Perhaps, we
do. Should we extend that test to non-English as well?

[dhollowa, 2011-01-11 20:07:08]

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
File chrome/test/data/autofill_heuristics/input/form_de.html (right):

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
chrome/test/data/autofill_heuristics/input/form_de.html:4: <meta
http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
On 2011/01/11 19:52:13, Jungshik Shin wrote:
> Just a thought (it does not matter at all): Perhaps, we just want to use HTML5
> doctype and simplify the above meta line to '<meta charset="UTF-8">'. It does
> not affect anything at all. It just occurred to me. 

Done.  Ya, nicer.

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
File chrome/test/data/autofill_heuristics/input/form_en.html (right):

http://codereview.chromium.org/6113005/diff/1/chrome/test/data/autofill_heuri...
chrome/test/data/autofill_heuristics/input/form_en.html:20: <label for="c1">Name
on card:</label> <input type="text" id="c1"><br>
We have a number of unit tests for testing other types of markup, yes.  But unit
tests are cumbersome to write... so more HTML-based tests that get picked up by
the FormStructureBrowserTest.HTMLFiles test would be fantastic.

We have an effort underway to add HTML files here for the top 100 sites.

Any extra HTML examples here would be most welcome.  One set that I'd like to
see are tests for are files that cover the ECML spec / RFC 3106.


On 2011/01/11 19:52:13, Jungshik Shin wrote:
> again not related to this CL (sorry for digressing): Do we have a test for
other
> ways of marking up the input field (other than using 'label' tag)? Perhaps, we
> do. Should we extend that test to non-English as well?