Issue 6111003: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.

Issue 6111003: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath. Fix the callers and remove the deprecated function. BUG=24672 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70705

Patch Set 1 #

Total comments: 2

Patch Set 2 : evan review #

Total comments: 2

Patch Set 3 : review2 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -48 lines)			Patch
M	base/file_util_deprecated.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	base/file_util_unittest.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	base/file_util_win.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/shell_dialogs_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/lzma_util.cc	View	1 2	1 chunk	+6 lines, -9 lines	0 comments	Download
M	chrome/installer/util/shell_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/6111003/diff/1/chrome/installer/util/lzma_util.cc File chrome/installer/util/lzma_util.cc (right): http://codereview.chromium.org/6111003/diff/1/chrome/installer/util/lzma_util.cc#newcode162 chrome/installer/util/lzma_util.cc:162: std::wstring file_name(location); Maybe better to make this a FilePath? ...

9 years, 11 months ago (2011-01-06 23:39:49 UTC) #2

tfarina

9 years, 11 months ago (2011-01-06 23:52:48 UTC) #3

Evan Martin

LGTM either way http://codereview.chromium.org/6111003/diff/5001/chrome/installer/util/lzma_util.cc File chrome/installer/util/lzma_util.cc (right): http://codereview.chromium.org/6111003/diff/5001/chrome/installer/util/lzma_util.cc#newcode163 chrome/installer/util/lzma_util.cc:163: file_path = file_path.Append(UTF8ToWide(f->Name)); Can write these ...

9 years, 11 months ago (2011-01-07 00:16:54 UTC) #4

tfarina

9 years, 11 months ago (2011-01-07 00:20:25 UTC) #5

http://codereview.chromium.org/6111003/diff/5001/chrome/installer/util/lzma_u...
File chrome/installer/util/lzma_util.cc (right):

http://codereview.chromium.org/6111003/diff/5001/chrome/installer/util/lzma_u...
chrome/installer/util/lzma_util.cc:163: file_path =
file_path.Append(UTF8ToWide(f->Name));
On 2011/01/07 00:16:54, Evan Martin wrote:
> Can write these lines as
> 
> FilePath file_path = FilePath(location).Append(UTF8ToWide(f->Name));
> 
> might be easier to read.  And I'd maybe remove the comment in L161 since it's
> kind of obvious.

Done.

Expand Messages | Collapse Messages