chrome/browser/ui/views/shell_dialogs_win.cc - Issue 6111003: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/shell_dialogs_win.cc

Issue 6111003: Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review2 Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/shell_dialogs_win.cc

diff --git a/chrome/browser/ui/views/shell_dialogs_win.cc b/chrome/browser/ui/views/shell_dialogs_win.cc

index 7405ef6d312662fa0e2f4a00ccfe50e803a750a5..f1c59b4f7ce922d5ade3217a6e15303862e74e14 100644

--- a/chrome/browser/ui/views/shell_dialogs_win.cc

+++ b/chrome/browser/ui/views/shell_dialogs_win.cc

@@ -270,7 +270,7 @@ bool SaveFileAsWithFilter(HWND owner,

save_as.nMaxFileTitle = 0;

// Set up the initial directory for the dialog.

- std::wstring directory = file_util::GetDirectoryFromPath(suggested_name);

+ std::wstring directory = FilePath(suggested_name).DirName().value();

save_as.lpstrInitialDir = directory.c_str();

save_as.lpstrTitle = NULL;

save_as.Flags = OFN_OVERWRITEPROMPT | OFN_EXPLORER | OFN_ENABLESIZING |

« no previous file with comments | « base/file_util_win.cc ('k') | chrome/installer/util/lzma_util.cc » ('j') | no next file with comments »