Allow the Mac theme provider to give default colors/tints if requested. Switc...

Allow the Mac theme provider to give default colors/tints if requested. Switch the download shelf's "open downloads" link to directly use the theme provider.

BUG=http://crbug.com/35554
TEST=no visible change in normal mode; incognito mode still being worked on

[pink (ping after 24hrs), 2010-02-16 22:51:05]

LGTM

http://codereview.chromium.org/611001/diff/3001/4003
File chrome/browser/browser_theme_provider_mac.mm (right):

http://codereview.chromium.org/611001/diff/3001/4003#newcode87
chrome/browser/browser_theme_provider_mac.mm:87: bool is_default;
worth initializing to a value, just to be safe?

[Avi (use Gerrit), 2010-02-16 23:02:32]

BTW, new rev up. Much cleaner way of doing it (it was done the way GTK did it,
but now we have a real API to ask if there was a default color rather than doing
color compares...)

http://codereview.chromium.org/611001/diff/3001/4003
File chrome/browser/browser_theme_provider_mac.mm (right):

http://codereview.chromium.org/611001/diff/3001/4003#newcode87
chrome/browser/browser_theme_provider_mac.mm:87: bool is_default;
On 2010/02/16 22:51:06, pink wrote:
> worth initializing to a value, just to be safe?

Must we? It's very clearly set on both branches...

[pink (ping after 24hrs), 2010-02-17 13:49:20]

On Tue, Feb 16, 2010 at 6:02 PM,  <avi@chromium.org> wrote:

> Must we? It's very clearly set on both branches...

Until the code changes and someone forgets to set it..... Was just a suggestion.

-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[Avi (use Gerrit), 2010-02-17 14:39:57]

On 2010/02/17 13:49:20, pink wrote:
> Until the code changes and someone forgets to set it..... Was just a
suggestion.

(shrug) OK.

[pink (ping after 24hrs), 2010-02-17 14:50:37]

If you want, I'll take another look at the "new way" after I get back
from a quick appt.

On Tue, Feb 16, 2010 at 6:02 PM,  <avi@chromium.org> wrote:
> BTW, new rev up. Much cleaner way of doing it (it was done the way GTK did
> it,
> but now we have a real API to ask if there was a default color rather than
> doing
> color compares...)
>
>
> http://codereview.chromium.org/611001/diff/3001/4003
> File chrome/browser/browser_theme_provider_mac.mm (right):
>
> http://codereview.chromium.org/611001/diff/3001/4003#newcode87
> chrome/browser/browser_theme_provider_mac.mm:87: bool is_default;
> On 2010/02/16 22:51:06, pink wrote:
>>
>> worth initializing to a value, just to be safe?
>
> Must we? It's very clearly set on both branches...
>
> http://codereview.chromium.org/611001
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[pink (ping after 24hrs), 2010-02-17 15:54:45]

SLGTM

http://codereview.chromium.org/611001/diff/9001/10006
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/611001/diff/9001/10006#newcode109
chrome/browser/cocoa/download_shelf_controller.mm:109: ThemeProvider* provider =
bridge_->browser()->profile()->GetThemeProvider();
the previous code was checking if (provider), do you still want to/need to?

[Avi (use Gerrit), 2010-02-17 16:30:25]

http://codereview.chromium.org/611001/diff/9001/10006
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/611001/diff/9001/10006#newcode109
chrome/browser/cocoa/download_shelf_controller.mm:109: ThemeProvider* provider =
bridge_->browser()->profile()->GetThemeProvider();
On 2010/02/17 15:54:45, pink wrote:
> the previous code was checking if (provider), do you still want to/need to?

Hm. Probably a good idea; I'm not convinced it was unnecessary...