Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 6107001: Instanceof slow case bind is incorrect.... (Closed)

Created:
9 years, 11 months ago by marklam
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Instanceof slow case bind is incorrect. Currently, the bind for the slow label is after the pushing of the args registers which renders the args pushing dead code because there is a Ret preceeding it. The comments also imply that the arg pushing should be part of the InvokeBuiltins tail call. Committed: http://code.google.com/p/v8/source/detail?r=6198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
marklam
My co-worker found this while merging 3.0.5. I'm not sure about the correctness of the ...
9 years, 11 months ago (2011-01-05 23:09:55 UTC) #1
Karl Klose
LGTM. The two arguments are object and function.
9 years, 11 months ago (2011-01-06 09:22:39 UTC) #2
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-06 12:42:16 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698