Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 6107001: Instanceof slow case bind is incorrect.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2969 matching lines...) Expand 10 before | Expand all | Expand 10 after
2980 __ mov(r0, Operand(Smi::FromInt(1))); 2980 __ mov(r0, Operand(Smi::FromInt(1)));
2981 __ Ret(HasArgsInRegisters() ? 0 : 2); 2981 __ Ret(HasArgsInRegisters() ? 0 : 2);
2982 2982
2983 __ bind(&object_not_null_or_smi); 2983 __ bind(&object_not_null_or_smi);
2984 // String values are not instances of anything. 2984 // String values are not instances of anything.
2985 __ IsObjectJSStringType(object, scratch, &slow); 2985 __ IsObjectJSStringType(object, scratch, &slow);
2986 __ mov(r0, Operand(Smi::FromInt(1))); 2986 __ mov(r0, Operand(Smi::FromInt(1)));
2987 __ Ret(HasArgsInRegisters() ? 0 : 2); 2987 __ Ret(HasArgsInRegisters() ? 0 : 2);
2988 2988
2989 // Slow-case. Tail call builtin. 2989 // Slow-case. Tail call builtin.
2990 __ bind(&slow);
2990 if (HasArgsInRegisters()) { 2991 if (HasArgsInRegisters()) {
2991 __ Push(r0, r1); 2992 __ Push(r0, r1);
2992 } 2993 }
2993 __ bind(&slow);
2994 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_JS); 2994 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_JS);
2995 } 2995 }
2996 2996
2997 2997
2998 void ArgumentsAccessStub::GenerateReadElement(MacroAssembler* masm) { 2998 void ArgumentsAccessStub::GenerateReadElement(MacroAssembler* masm) {
2999 // The displacement is the offset of the last parameter (if any) 2999 // The displacement is the offset of the last parameter (if any)
3000 // relative to the frame pointer. 3000 // relative to the frame pointer.
3001 static const int kDisplacement = 3001 static const int kDisplacement =
3002 StandardFrameConstants::kCallerSPOffset - kPointerSize; 3002 StandardFrameConstants::kCallerSPOffset - kPointerSize;
3003 3003
(...skipping 1976 matching lines...) Expand 10 before | Expand all | Expand 10 after
4980 __ pop(r1); 4980 __ pop(r1);
4981 __ Jump(r2); 4981 __ Jump(r2);
4982 } 4982 }
4983 4983
4984 4984
4985 #undef __ 4985 #undef __
4986 4986
4987 } } // namespace v8::internal 4987 } } // namespace v8::internal
4988 4988
4989 #endif // V8_TARGET_ARCH_ARM 4989 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698