Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4807)

Unified Diff: chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Issue 6106003: Similar as extension, DOM UI needs to be created in its own process.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/render_view_host_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_host_manager_unittest.cc
===================================================================
--- chrome/browser/tab_contents/render_view_host_manager_unittest.cc (revision 70813)
+++ chrome/browser/tab_contents/render_view_host_manager_unittest.cc (working copy)
@@ -253,8 +253,6 @@
EXPECT_TRUE(host);
EXPECT_TRUE(host == manager.current_host());
EXPECT_FALSE(manager.pending_render_view_host());
- EXPECT_TRUE(manager.pending_dom_ui());
- EXPECT_FALSE(manager.dom_ui());
// It's important that the site instance get set on the DOM UI page as soon
// as the navigation starts, rather than lazily after it commits, so we don't
@@ -263,11 +261,13 @@
EXPECT_TRUE(host->site_instance()->has_site());
EXPECT_EQ(url, host->site_instance()->site());
+ // The DOM UI is committed immediately because the RenderViewHost has not been
+ // used yet. UpdateRendererStateForNavigate() took the short cut path.
+ EXPECT_FALSE(manager.pending_dom_ui());
+ EXPECT_TRUE(manager.dom_ui());
+
// Commit.
manager.DidNavigateMainFrame(host);
-
- EXPECT_FALSE(manager.pending_dom_ui());
- EXPECT_TRUE(manager.dom_ui());
}
// Tests that chrome: URLs that are not DOM UI pages do not get grouped into
« no previous file with comments | « chrome/browser/tab_contents/render_view_host_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698