Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/browser/tab_contents/render_view_host_manager.cc

Issue 6106003: Similar as extension, DOM UI needs to be created in its own process.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_host_manager.cc
===================================================================
--- chrome/browser/tab_contents/render_view_host_manager.cc (revision 70813)
+++ chrome/browser/tab_contents/render_view_host_manager.cc (working copy)
@@ -298,6 +298,12 @@
// into the same process.
if (new_entry->url().SchemeIs(chrome::kExtensionScheme))
return true;
+ // When a tab is created, it starts as TYPE_NORMAL. If the new entry is a
+ // DOM UI page, it needs to be grouped with other DOM UI pages. This matches
+ // the logic when transitioning between DOM UI and normal pages.
+ Profile* profile = delegate_->GetControllerForRenderManager().profile();
+ if (DOMUIFactory::UseDOMUIForURL(profile, new_entry->url()))
+ return true;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698