Issue 6100007: Revert 70782 - Made logging not look up --enable-dcheck from command line...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6100007: Revert 70782 - Made logging not look up --enable-dcheck from command line... (Closed)

Created:
9 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, Raghu Simha, amit, ncarter (slow), darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, tim (not reviewing), ceee-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 70782 - Made logging not look up --enable-dcheck from command line Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70783

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -103 lines)			Patch
M	base/logging.h	View	4 chunks	+7 lines, -16 lines	0 comments	Download
M	base/logging.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/test/test_suite.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	ceee/ie/broker/broker_module.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ceee/ie/plugin/toolband/toolband_module.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ceee/installer_dll/installer_helper.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/common/logging_chrome.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/installer/util/logging_installer.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/tools/crash_service/main.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome_frame/chrome_tab.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome_frame/crash_reporting/minidump_test.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	courgette/courgette_tool.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	net/tools/flip_server/flip_in_mem_edsm_server.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/testserver/run_testserver.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	net/tools/tld_cleanup/tld_cleanup.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages