Issue 6070006: Made logging not look up --enable-dcheck from command line

Issue 6070006: Made logging not look up --enable-dcheck from command line (Closed)

Created:
10 years ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, amit, cbentzel+watch_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, tim (not reviewing), ceee-reviews_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Made logging not look up --enable-dcheck from command line Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70977

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Darin's comments, fixed compile failure #

Patch Set 3 : Fixed release-mode compile failures #

Patch Set 4 : Fixed more compile failures #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -62 lines)			Patch
M	base/logging.h	View	1 2	4 chunks	+16 lines, -7 lines	0 comments	Download
M	base/logging.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/logging_unittest.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/test/test_suite.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	ceee/ie/broker/broker_module.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ceee/ie/plugin/toolband/toolband_module.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	ceee/installer_dll/installer_helper.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/common/logging_chrome.cc	View	1 2 3	2 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/installer/util/logging_installer.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/tools/crash_service/main.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_tab.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome_frame/crash_reporting/minidump_test.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	courgette/courgette_tool.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	net/tools/flip_server/flip_in_mem_edsm_server.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/tools/testserver/run_testserver.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	net/tools/tld_cleanup/tld_cleanup.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	o3d/plugin/cross/main.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	o3d/plugin/cross/main_remote_cb.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/support/webkit_support.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/6070006/diff/1/base/logging.h File base/logging.h (right): http://codereview.chromium.org/6070006/diff/1/base/logging.h#newcode611 base/logging.h:611: // This is set to true in InitLogging ...

9 years, 11 months ago (2011-01-03 06:53:32 UTC) #2

akalin

9 years, 11 months ago (2011-01-04 19:26:45 UTC) #3

Done, checking in as soon as trybots pass

http://codereview.chromium.org/6070006/diff/1/base/logging.h
File base/logging.h (right):

http://codereview.chromium.org/6070006/diff/1/base/logging.h#newcode611
base/logging.h:611: // This is set to true in InitLogging when we want to enable
the
On 2011/01/03 06:53:32, brettw wrote:
> Can you bring this comment up-to-date? Or maybe it's not necessary at all any
> more because of the EXTREMELY_DESCRIPTIVE_MACRO_NAME.

Done.

Expand Messages | Collapse Messages