Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 6098006: Fix a lot of casing and ellipsis bugs on options dialog buttons (Closed)

Created:
9 years, 11 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a lot of casing and ellipsis bugs on options dialog buttons BUG=68809 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70820

Patch Set 1 #

Patch Set 2 : can't use nested ifs #

Total comments: 8

Patch Set 3 : review fixes #

Patch Set 4 : str prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -106 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 19 chunks +199 lines, -102 lines 0 comments Download
M chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/exceptions_page_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
first pass. not complete.
9 years, 11 months ago (2011-01-07 01:47:24 UTC) #1
stuartmorgan
http://codereview.chromium.org/6098006/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6098006/diff/2001/chrome/app/generated_resources.grd#newcode4673 chrome/app/generated_resources.grd:4673: <message name="IDS_PASSWORDS_PAGE_VIEW_REMOVE_ALL_BUTTON" desc="Passwords page view's 'Remove all' button text"> ...
9 years, 11 months ago (2011-01-07 17:06:58 UTC) #2
Evan Stade
http://codereview.chromium.org/6098006/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6098006/diff/2001/chrome/app/generated_resources.grd#newcode4673 chrome/app/generated_resources.grd:4673: <message name="IDS_PASSWORDS_PAGE_VIEW_REMOVE_ALL_BUTTON" desc="Passwords page view's 'Remove all' button text"> ...
9 years, 11 months ago (2011-01-07 19:32:28 UTC) #3
stuartmorgan
I don't know enough about how the translators work to have an informed opinion, I ...
9 years, 11 months ago (2011-01-07 19:39:05 UTC) #4
Evan Stade
ok done.
9 years, 11 months ago (2011-01-07 23:42:59 UTC) #5
stuartmorgan
9 years, 11 months ago (2011-01-08 00:08:40 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698