Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/ui/views/options/exceptions_page_view.cc

Issue 6098006: Fix a lot of casing and ellipsis bugs on options dialog buttons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: str prefix Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/options/exceptions_page_view.h" 5 #include "chrome/browser/views/options/exceptions_page_view.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 : OptionsPageView(profile), 69 : OptionsPageView(profile),
70 ALLOW_THIS_IN_INITIALIZER_LIST(show_button_( 70 ALLOW_THIS_IN_INITIALIZER_LIST(show_button_(
71 this, 71 this,
72 UTF16ToWide(l10n_util::GetStringUTF16( 72 UTF16ToWide(l10n_util::GetStringUTF16(
73 IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON)), 73 IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON)),
74 UTF16ToWide(l10n_util::GetStringUTF16( 74 UTF16ToWide(l10n_util::GetStringUTF16(
75 IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON)))), 75 IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON)))),
76 ALLOW_THIS_IN_INITIALIZER_LIST(remove_button_( 76 ALLOW_THIS_IN_INITIALIZER_LIST(remove_button_(
77 this, 77 this,
78 UTF16ToWide(l10n_util::GetStringUTF16( 78 UTF16ToWide(l10n_util::GetStringUTF16(
79 IDS_EXCEPTIONS_PAGE_VIEW_REMOVE_BUTTON)))), 79 IDS_PASSWORDS_PAGE_VIEW_REMOVE_BUTTON)))),
80 ALLOW_THIS_IN_INITIALIZER_LIST(remove_all_button_( 80 ALLOW_THIS_IN_INITIALIZER_LIST(remove_all_button_(
81 this, 81 this,
82 UTF16ToWide(l10n_util::GetStringUTF16( 82 UTF16ToWide(l10n_util::GetStringUTF16(
83 IDS_EXCEPTIONS_PAGE_VIEW_REMOVE_ALL_BUTTON)))), 83 IDS_PASSWORDS_PAGE_VIEW_REMOVE_ALL_BUTTON)))),
84 table_model_(profile), 84 table_model_(profile),
85 table_view_(NULL) { 85 table_view_(NULL) {
86 } 86 }
87 87
88 ExceptionsPageView::~ExceptionsPageView() { 88 ExceptionsPageView::~ExceptionsPageView() {
89 // The model is going away, prevent the table from accessing it. 89 // The model is going away, prevent the table from accessing it.
90 if (table_view_) 90 if (table_view_)
91 table_view_->SetModel(NULL); 91 table_view_->SetModel(NULL);
92 } 92 }
93 93
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 columns.back().sortable = true; 188 columns.back().sortable = true;
189 table_view_ = new views::TableView(&table_model_, columns, views::TEXT_ONLY, 189 table_view_ = new views::TableView(&table_model_, columns, views::TEXT_ONLY,
190 true, true, true); 190 true, true, true);
191 // Make the table initially sorted by host. 191 // Make the table initially sorted by host.
192 views::TableView::SortDescriptors sort; 192 views::TableView::SortDescriptors sort;
193 sort.push_back(views::TableView::SortDescriptor( 193 sort.push_back(views::TableView::SortDescriptor(
194 IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN, true)); 194 IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN, true));
195 table_view_->SetSortDescriptors(sort); 195 table_view_->SetSortDescriptors(sort);
196 table_view_->SetObserver(this); 196 table_view_->SetObserver(this);
197 } 197 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/options/passwords_exceptions_page_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698