Put history insertion for downloads processing inline.

chrome/browser/download/download_manager.h

Index: chrome/browser/download/download_manager.h
diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h
index 4f5ebcfb1cbcb6722f35c05b30642787927fb08e..a6e5543be43b1790bf73165fac0d473a01b1f3af 100644
--- a/chrome/browser/download/download_manager.h
+++ b/chrome/browser/download/download_manager.h
@@ -125,6 +125,17 @@ class DownloadManager
   void PauseDownload(int32 download_id, bool pause);
   void RemoveDownload(int64 download_handle);
 
+  // Determine if the download is ready for completion, i.e. has had
+  // all data received, and completed the filename determination and
+  // history insertion.
+  bool DownloadReadyForCompletion(int32 download_id);

[Paweł Hajdan Jr., 2011/01/05 07:46:30]

nit: Can we rename it to IsDownloadReadyForCompletion, to avoid confusion with
an outside notification that the download is ready for completion? Or maybe
simpler IsDownloadComplete?

nit: We have now two very similar concepts of completion in the download system:
"completed" and "finished". This is probably not something that can be fixed in
this CL, but it would be nice to remove this confusion or at least explain it.

[Randy Smith (Not in Mondays), 2011/01/13 02:13:24]

Changed to IsDownloadReadyForCompletion() (IsDownloadComplete() isn't accurate;
it isn't complete until we finish what we're doing).
I think my other CL is doing some of this; specifically, we're moving
DownloadItem::COMPLETE to mean "really done" and the intermediate state is
DATA_RECEIVED.  We need to get ride of pending_finished_downloads_ (which I want
to do anyway) and it may take a little while to bring all the comments up to
date with that nomenclature.  I'll take an AI to take a swing at that.

+
+  // If all pre-requisites have been met, complete download processing, i.e.
+  // do internal cleanup, file rename, and potentially auto-open.
+  // (Dangerous downloads still may block on user acceptance after this
+  // point.)
+  void MaybeCompleteDownload(int32 download_id, int64 size);
+
   // Called when the download is renamed to its final name.
   void DownloadRenamedToFinalName(int download_id, const FilePath& full_path);