Put history insertion for downloads processing inline.

chrome/browser/download/download_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active profile in Chrome.
 //
 // Download observers:
@@ skipping 107 matching lines @@
   // Notifications sent from the download thread to the UI thread
   void StartDownload(DownloadCreateInfo* info);
   void UpdateDownload(int32 download_id, int64 size);
   void OnAllDataSaved(int32 download_id, int64 size);
 
   // Called from a view when a user clicks a UI button or link.
   void DownloadCancelled(int32 download_id);
   void PauseDownload(int32 download_id, bool pause);
   void RemoveDownload(int64 download_handle);
 
+  // Determine if the download is ready for completion, i.e. has had
+  // all data received, and completed the filename determination and
+  // history insertion.
+  bool DownloadReadyForCompletion(int32 download_id);

[Paweł Hajdan Jr., 2011/01/05 07:46:30]

nit: Can we rename it to IsDownloadReadyForCompletion, to avoid confusion with
an outside notification that the download is ready for completion? Or maybe
simpler IsDownloadComplete?

nit: We have now two very similar concepts of completion in the download system:
"completed" and "finished". This is probably not something that can be fixed in
this CL, but it would be nice to remove this confusion or at least explain it.

[Randy Smith (Not in Mondays), 2011/01/13 02:13:24]

Changed to IsDownloadReadyForCompletion() (IsDownloadComplete() isn't accurate;
it isn't complete until we finish what we're doing).
I think my other CL is doing some of this; specifically, we're moving
DownloadItem::COMPLETE to mean "really done" and the intermediate state is
DATA_RECEIVED.  We need to get ride of pending_finished_downloads_ (which I want
to do anyway) and it may take a little while to bring all the comments up to
date with that nomenclature.  I'll take an AI to take a swing at that.

+
+  // If all pre-requisites have been met, complete download processing, i.e.
+  // do internal cleanup, file rename, and potentially auto-open.
+  // (Dangerous downloads still may block on user acceptance after this
+  // point.)
+  void MaybeCompleteDownload(int32 download_id, int64 size);
+
   // Called when the download is renamed to its final name.
   void DownloadRenamedToFinalName(int download_id, const FilePath& full_path);
 
   // Remove downloads after remove_begin (inclusive) and before remove_end
   // (exclusive). You may pass in null Time values to do an unbounded delete
   // in either direction.
   int RemoveDownloadsBetween(const base::Time remove_begin,
                              const base::Time remove_end);
 
   // Remove downloads will delete all downloads that have a timestamp that is
@@ skipping 233 matching lines @@
   // The "Save As" dialog box used to ask the user where a file should be
   // saved.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_