chrome/browser/download/save_package.cc - Issue 6096003: Put history insertion for downloads processing inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_package.cc

Issue 6096003: Put history insertion for downloads processing inline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Pawel's comments. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/save_package.cc

diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc

index 23c062c83cfbeaa987c88abdc3c303940f8d46df..defa09b15f1b93d52f8c38a6f1b11f0b142e74b6 100644

--- a/chrome/browser/download/save_package.cc

+++ b/chrome/browser/download/save_package.cc

@@ -687,8 +687,9 @@ void SavePackage::Finish() {

save_ids));

download_->OnAllDataSaved(all_save_items_count_);

+ download_->MarkAsComplete();

// Notify download observers that we are complete (the call

- // to OnAllDataSaved() set the state to complete but did not notify).

+ // to OnReadyToFinish() set the state to complete but did not notify).

download_->UpdateObservers();

NotificationService::current()->Notify(

« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | no next file » | no next file with comments »