Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 6096003: Put history insertion for downloads processing inline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Pawel's comments. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | chrome/browser/download/save_package.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index 2db13be7f78705e741004d86ae543bde01ac1c63..d6fa2c43f37c8aaaf2cd92f21bd33dd7d0426079 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -157,28 +157,29 @@ const struct {
bool will_delete_crdownload;
int expected_rename_count;
} kDownloadRenameCases[] = {
- // Safe download, download finishes BEFORE rename.
- // Needs to be renamed only once. Crdownload file needs to be deleted.
+ // Safe download, download finishes BEFORE file name determined.
+ // Renamed twice (linear path through UI). Crdownload file does not need
+ // to be deleted.
{ FILE_PATH_LITERAL("foo.zip"),
false,
true,
- true,
- 1, },
- // Dangerous download, download finishes BEFORE rename.
+ false,
+ 2, },
+ // Dangerous download, download finishes BEFORE file name determined.
// Needs to be renamed only once.
{ FILE_PATH_LITERAL("unconfirmed xxx.crdownload"),
true,
true,
false,
1, },
- // Safe download, download finishes AFTER rename.
+ // Safe download, download finishes AFTER file name determined.
// Needs to be renamed twice.
{ FILE_PATH_LITERAL("foo.zip"),
false,
false,
false,
2, },
- // Dangerous download, download finishes AFTER rename.
+ // Dangerous download, download finishes AFTER file name determined.
// Needs to be renamed only once.
{ FILE_PATH_LITERAL("unconfirmed xxx.crdownload"),
true,
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | chrome/browser/download/save_package.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698