Put history insertion for downloads processing inline.

chrome/browser/download/download_item.h

Index: chrome/browser/download/download_item.h
diff --git a/chrome/browser/download/download_item.h b/chrome/browser/download/download_item.h
index 7471994d06362483bb21f0343a59254aef42cbbf..ad41c6cccc9229bf4bd04716c4cf9e79cc13ffb5 100644
--- a/chrome/browser/download/download_item.h
+++ b/chrome/browser/download/download_item.h
@@ -40,8 +40,18 @@ class DownloadItem {
  public:
   enum DownloadState {
     IN_PROGRESS,
+
+    // Note that COMPLETE indicates that the download has gotten all of its
+    // data, has figured out its final destination file, has been entered
+    // into the history store, and has been shown in the UI.  The only
+    // operations remaining are (possibly) acceptance by the user of
+    // a dangerous download, and renaming the file to the final name and

[Paweł Hajdan Jr., 2011/01/17 18:13:24]

nit: "and..." - is the later part of this comment missing?

[Randy Smith (Not in Mondays), 2011/01/18 22:32:46]

Done.

     COMPLETE,
+
     CANCELLED,
+
+    // This state indicates that the download item is about to be destroyed,
+    // and observers seeing this state should release all references.
     REMOVING
   };
 
@@ -129,7 +139,7 @@ class DownloadItem {
   void Cancel(bool update_history);
 
   // Called when all data has been saved.
-  void OnAllDataSaved(int64 size);
+  void OnReadyToFinish(int64 size);
 
   // Called when the entire download operation (including renaming etc)
   // is finished.