Put history insertion for downloads processing inline.

chrome/browser/download/download_item.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
 // are owned by the DownloadManager which maintains a global list of all
 // downloads. DownloadItems are created when a user initiates a download,
 // and exist for the duration of the browser life time.
 //
 // Download observers:
@@ skipping 22 matching lines @@
 
 // One DownloadItem per download. This is the model class that stores all the
 // state for a download. Multiple views, such as a tab's download shelf and the
 // Destination tab's download view, may refer to a given DownloadItem.
 //
 // This is intended to be used only on the UI thread.
 class DownloadItem {
  public:
   enum DownloadState {
     IN_PROGRESS,
+
+    // Note that COMPLETE indicates that the download has gotten all of its
+    // data, has figured out its final destination file, has been entered
+    // into the history store, and has been shown in the UI.  The only
+    // operations remaining are (possibly) acceptance by the user of
+    // a dangerous download, and renaming the file to the final name and

[Paweł Hajdan Jr., 2011/01/17 18:13:24]

nit: "and..." - is the later part of this comment missing?

[Randy Smith (Not in Mondays), 2011/01/18 22:32:46]

Done.

     COMPLETE,
+
     CANCELLED,
+
+    // This state indicates that the download item is about to be destroyed,
+    // and observers seeing this state should release all references.
     REMOVING
   };
 
   enum SafetyState {
     SAFE = 0,
     DANGEROUS,
     DANGEROUS_BUT_VALIDATED  // Dangerous but the user confirmed the download.
   };
 
   // Interface that observers of a particular download must implement in order
@@ skipping 67 matching lines @@
   // because at exit, the history system may not exist, and any updates to it
   // require AddRef'ing the DownloadManager in the destructor which results in
   // a DCHECK failure. Set 'update_history' to false when canceling from at
   // exit to prevent this crash. This may result in a difference between the
   // downloaded file's size on disk, and what the history system's last record
   // of it is. At worst, we'll end up re-downloading a small portion of the file
   // when resuming a download (assuming the server supports byte ranges).
   void Cancel(bool update_history);
 
   // Called when all data has been saved.
-  void OnAllDataSaved(int64 size);
+  void OnReadyToFinish(int64 size);
 
   // Called when the entire download operation (including renaming etc)
   // is finished.
   void Finished();
 
   // The user wants to remove the download from the views and history. If
   // |delete_file| is true, the file is deleted on the disk.
   void Remove(bool delete_file);
 
   // Simple calculation of the amount of time remaining to completion. Fills
@@ skipping 195 matching lines @@
   // Did the user open the item either directly or indirectly (such as by
   // setting always open files of this type)? The shelf also sets this field
   // when the user closes the shelf before the item has been opened but should
   // be treated as though the user opened it.
   bool opened_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItem);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_H_