Issue 6094004: Bring back 'navigated' notification for --remote-shell-port protocol

Issue 6094004: Bring back 'navigated' notification for --remote-shell-port protocol (Closed)

Created:
9 years, 12 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, yurys

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Bring back 'navigated' notification for --remote-shell-port protocol Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72498

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
M	chrome/browser/debugger/devtools_client_host.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/debugger/devtools_manager.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/devtools_manager_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/inspectable_tab_proxy.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/inspectable_tab_proxy.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_devtools_bridge.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM with nit. http://codereview.chromium.org/6094004/diff/1/chrome/browser/debugger/devtools_client_host.h File chrome/browser/debugger/devtools_client_host.h (right): http://codereview.chromium.org/6094004/diff/1/chrome/browser/debugger/devtools_client_host.h#newcode41 chrome/browser/debugger/devtools_client_host.h:41: virtual void FrameNavigating(const std::string& url) {}; ...

9 years, 11 months ago (2011-01-18 16:03:48 UTC) #3

Peter Rybin

9 years, 11 months ago (2011-01-19 15:36:02 UTC) #4

http://codereview.chromium.org/6094004/diff/1/chrome/browser/debugger/devtool...
File chrome/browser/debugger/devtools_client_host.h (right):

http://codereview.chromium.org/6094004/diff/1/chrome/browser/debugger/devtool...
chrome/browser/debugger/devtools_client_host.h:41: virtual void
FrameNavigating(const std::string& url) {};
On 2011/01/18 16:03:48, pfeldman wrote:
> This method can be a part of the devtools client interface (pure).

Done.

Expand Messages | Collapse Messages