Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/debugger/devtools_client_host.h

Issue 6094004: Bring back 'navigated' notification for --remote-shell-port protocol (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string>
10
9 #include "base/basictypes.h" 11 #include "base/basictypes.h"
10 12
11 namespace IPC { 13 namespace IPC {
12 class Message; 14 class Message;
13 } 15 }
14 16
15 class DevToolsWindow; 17 class DevToolsWindow;
16 18
17 // Describes interface for managing devtools clients from browser process. There 19 // Describes interface for managing devtools clients from browser process. There
18 // are currently two types of clients: devtools windows and TCP socket 20 // are currently two types of clients: devtools windows and TCP socket
19 // debuggers. 21 // debuggers.
20 class DevToolsClientHost { 22 class DevToolsClientHost {
21 public: 23 public:
22 class CloseListener { 24 class CloseListener {
23 public: 25 public:
24 CloseListener() {} 26 CloseListener() {}
25 virtual ~CloseListener() {} 27 virtual ~CloseListener() {}
26 virtual void ClientHostClosing(DevToolsClientHost* host) = 0; 28 virtual void ClientHostClosing(DevToolsClientHost* host) = 0;
27 private: 29 private:
28 DISALLOW_COPY_AND_ASSIGN(CloseListener); 30 DISALLOW_COPY_AND_ASSIGN(CloseListener);
29 }; 31 };
30 32
31 virtual ~DevToolsClientHost() {} 33 virtual ~DevToolsClientHost() {}
32 34
33 // This method is called when tab inspected by this devtools client is 35 // This method is called when tab inspected by this devtools client is
34 // closing. 36 // closing.
35 virtual void InspectedTabClosing() = 0; 37 virtual void InspectedTabClosing() = 0;
36 38
39 // This method is called when tab inspected by this devtools client is
40 // navigating to |url|.
41 virtual void FrameNavigating(const std::string& url) {};
pfeldman 2011/01/18 16:03:48 This method can be a part of the devtools client i
Peter Rybin 2011/01/19 15:36:02 Done.
42
37 // Sends the message to the devtools client hosted by this object. 43 // Sends the message to the devtools client hosted by this object.
38 virtual void SendMessageToClient(const IPC::Message& msg) = 0; 44 virtual void SendMessageToClient(const IPC::Message& msg) = 0;
39 45
40 void set_close_listener(CloseListener* listener) { 46 void set_close_listener(CloseListener* listener) {
41 close_listener_ = listener; 47 close_listener_ = listener;
42 } 48 }
43 49
44 virtual DevToolsWindow* AsDevToolsWindow(); 50 virtual DevToolsWindow* AsDevToolsWindow();
45 51
46 protected: 52 protected:
47 DevToolsClientHost() : close_listener_(NULL) {} 53 DevToolsClientHost() : close_listener_(NULL) {}
48 54
49 // Should be called when the devtools client is going to die and this 55 // Should be called when the devtools client is going to die and this
50 // DevToolsClientHost should not be used anymore. 56 // DevToolsClientHost should not be used anymore.
51 void NotifyCloseListener(); 57 void NotifyCloseListener();
52 58
53 private: 59 private:
54 CloseListener* close_listener_; 60 CloseListener* close_listener_;
55 DISALLOW_COPY_AND_ASSIGN(DevToolsClientHost); 61 DISALLOW_COPY_AND_ASSIGN(DevToolsClientHost);
56 }; 62 };
57 63
58 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_ 64 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698