Issue 6092005: Remove base/debug_util. Move the debug UI related functions to base/debug/deb...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6092005: Remove base/debug_util. Move the debug UI related functions to base/debug/deb... (Closed)

Created:
9 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove base/debug_util. Move the debug UI related functions to base/debug/debugger.h Move the OS X specific crash report changing function to base/mac/os_crash_dumps TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70358

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -100 lines)			Patch
M	app/resource_bundle_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	base/debug/debugger.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/debug/debugger.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	base/debug/debugger_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/debug/debugger_win.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	base/debug_util.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	base/debug_util.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	base/debug_util_mac.cc	View	1 chunk	+0 lines, -37 lines	0 comments	Download
A	base/mac/os_crash_dumps.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	base/mac/os_crash_dumps.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	base/process_util_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/test/test_suite.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/app/chrome_main.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/cocoa_test_helper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/objc_zombie.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/sandbox_mac.mm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages