Issue 6092004: Strip quotes from stringified cookie values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6092004: Strip quotes from stringified cookie values. (Closed)

Created:
9 years, 12 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
nsylvain, Paweł Hajdan Jr.

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/page_cycler

Visibility:
Public.

Description

Strip quotes from stringified cookie values. BUG=68218 TEST=page cycler timings results are printed without quotes TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70279

Patch Set 1 #

Total comments: 2

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/test/page_cycler/page_cycler_test.cc	View		2 chunks	+10 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

http://codereview.chromium.org/6092004/diff/1/chrome/test/page_cycler/page_cycler_test.cc File chrome/test/page_cycler/page_cycler_test.cc (right): http://codereview.chromium.org/6092004/diff/1/chrome/test/page_cycler/page_cycler_test.cc#newcode264 chrome/test/page_cycler/page_cycler_test.cc:264: cookie = cookie.substr(start_idx+1, end_idx-start_idx-1); end_idx-1 maybe?

9 years, 12 months ago (2010-12-29 21:22:14 UTC) #1

nsylvain

9 years, 12 months ago (2010-12-29 21:37:43 UTC) #2

http://codereview.chromium.org/6092004/diff/1/chrome/test/page_cycler/page_cy...
File chrome/test/page_cycler/page_cycler_test.cc (right):

http://codereview.chromium.org/6092004/diff/1/chrome/test/page_cycler/page_cy...
chrome/test/page_cycler/page_cycler_test.cc:264: cookie =
cookie.substr(start_idx+1, end_idx-start_idx-1);
On 2010/12/29 21:22:14, nsylvain wrote:
> end_idx-1 maybe?
did not read correctly. LGTM

Expand Messages | Collapse Messages