Strip quotes from stringified cookie values.

chrome/test/page_cycler/page_cycler_test.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
@@ skipping 228 matching lines @@
     ASSERT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS, tab->NavigateToURL(test_url));
 
     // Wait for the test to finish.
     ASSERT_TRUE(WaitUntilCookieValue(tab.get(), test_url, "__pc_done",
                                      UITest::test_timeout_ms(), "1"));
 
     std::string cookie;
     ASSERT_TRUE(tab->GetCookieByName(test_url, "__pc_pages", &cookie));
     pages->assign(UTF8ToWide(cookie));
     ASSERT_FALSE(pages->empty());
-    ASSERT_TRUE(tab->GetCookieByName(test_url, "__pc_timings", &cookie));
 
+    // Get the timing cookie value from the DOM automation.
     std::wstring wcookie;
     ASSERT_TRUE(tab->ExecuteAndExtractString(L"",
           L"window.domAutomationController.send("
           L"JSON.stringify(__get_timings()));",
           &wcookie));
     cookie = base::SysWideToNativeMB(wcookie);
 
+    // JSON.stringify() encapsulates the returned string in quotes, strip them.
+    std::string::size_type start_idx = cookie.find("\"");
+    std::string::size_type end_idx = cookie.find_last_of("\"");
+    if (start_idx != std::string::npos &&
+        end_idx != std::string::npos &&
+        start_idx < end_idx) {
+      cookie = cookie.substr(start_idx+1, end_idx-start_idx-1);

[nsylvain, 2010/12/29 21:22:14]

end_idx-1 maybe?

[nsylvain, 2010/12/29 21:37:43]

did not read correctly. LGTM

+    }
+
     timings->assign(cookie);
     ASSERT_FALSE(timings->empty());
   }
 
   // When use_http is true, the test name passed here will be used directly in
   // the path to the test data, so it must be safe for use in a URL without
   // escaping. (No pound (#), question mark (?), semicolon (;), non-ASCII, or
   // other funny stuff.)
   void RunTestWithSuffix(const char* graph, const char* name, bool use_http,
                          const char* suffix) {
@@ skipping 311 matching lines @@
 #endif
 
 // Indexed DB tests.
 // Disabled in debug builds on Windows.
 // Bug http://code.google.com/p/chromium/issues/detail?id=67918
 #if !defined(OS_WIN) || defined(NDEBUG)
 PAGE_CYCLER_IDB_TESTS("basic_insert", BasicInsert);
 #endif
 
 }  // namespace