Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7600)

Unified Diff: chrome/installer/util/package_unittest.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/package_unittest.cc
===================================================================
--- chrome/installer/util/package_unittest.cc (revision 71561)
+++ chrome/installer/util/package_unittest.cc (working copy)
@@ -137,14 +137,15 @@
bool SetUninstallArguments(HKEY root, BrowserDistribution* dist,
const CommandLine& args) {
RegKey key(root, dist->GetStateKey().c_str(), KEY_ALL_ACCESS);
- return key.WriteValue(installer::kUninstallArgumentsField,
- args.command_line_string().c_str());
+ return (key.WriteValue(installer::kUninstallArgumentsField,
+ args.command_line_string().c_str()) == ERROR_SUCCESS);
}
bool SetInstalledVersion(HKEY root, BrowserDistribution* dist,
const std::wstring& version) {
RegKey key(root, dist->GetVersionKey().c_str(), KEY_ALL_ACCESS);
- return key.WriteValue(google_update::kRegVersionField, version.c_str());
+ return (key.WriteValue(google_update::kRegVersionField, version.c_str())
+ == ERROR_SUCCESS);
grt (UTC plus 2) 2011/01/16 04:19:48 Wrapping and indentation
}
} // end namespace

Powered by Google App Engine
This is Rietveld 408576698