Regkey functions return error code instead of bool

chrome/installer/util/package_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_handle.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_constants.h"
@@ skipping 119 matching lines @@
         EXPECT_TRUE(current_version->Equals(*found_version));
       }
     }
   }
 }
 
 namespace {
 bool SetUninstallArguments(HKEY root, BrowserDistribution* dist,
                            const CommandLine& args) {
   RegKey key(root, dist->GetStateKey().c_str(), KEY_ALL_ACCESS);
-  return key.WriteValue(installer::kUninstallArgumentsField,
-                        args.command_line_string().c_str());
+  return (key.WriteValue(installer::kUninstallArgumentsField,
+                         args.command_line_string().c_str()) == ERROR_SUCCESS);
 }
 
 bool SetInstalledVersion(HKEY root, BrowserDistribution* dist,
                          const std::wstring& version) {
   RegKey key(root, dist->GetVersionKey().c_str(), KEY_ALL_ACCESS);
-  return key.WriteValue(google_update::kRegVersionField, version.c_str());
+  return (key.WriteValue(google_update::kRegVersionField, version.c_str())
+      == ERROR_SUCCESS);

[grt (UTC plus 2), 2011/01/16 04:19:48]

Wrapping and indentation

 }
 }  // end namespace
 
 TEST_F(PackageTest, Dependency) {
   const bool multi_install = false;
   const bool system_level = true;
   HKEY root = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   TempRegKeyOverride override(root, L"root_dep");
 
   ChromePackageProperties properties;
@@ skipping 22 matching lines @@
 
   // "install" Chrome Frame without multi-install.
   SetUninstallArguments(root, cf, single_uninstall_cmd);
   SetInstalledVersion(root, cf, L"1.2.3.4");
   EXPECT_EQ(1U, package->GetMultiInstallDependencyCount());
 
   // "install" Chrome Frame with multi-install.
   SetUninstallArguments(root, cf, multi_uninstall_cmd);
   EXPECT_EQ(2U, package->GetMultiInstallDependencyCount());
 }