Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3831)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/package_unittest.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/delete_reg_value_work_item.cc ('K') | « chrome/installer/util/package_properties_unittest.cc ('k') | chrome/installer/util/product.cc » ('j') | chrome/installer/util/set_reg_value_work_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/package_unittest.cc
===================================================================
--- chrome/installer/util/package_unittest.cc (revision 71345)
+++ chrome/installer/util/package_unittest.cc (working copy)
@@ -138,13 +138,14 @@
const CommandLine& args) {
RegKey key(root, dist->GetStateKey().c_str(), KEY_ALL_ACCESS);
return key.WriteValue(installer::kUninstallArgumentsField,
- args.command_line_string().c_str());
+ args.command_line_string().c_str()) == ERROR_SUCCESS;
}
bool SetInstalledVersion(HKEY root, BrowserDistribution* dist,
const std::wstring& version) {
RegKey key(root, dist->GetVersionKey().c_str(), KEY_ALL_ACCESS);
- return key.WriteValue(google_update::kRegVersionField, version.c_str());
+ LONG ret = key.WriteValue(google_update::kRegVersionField, version.c_str());
+ return ret == ERROR_SUCCESS;
}
} // end namespace
« chrome/installer/util/delete_reg_value_work_item.cc ('K') | « chrome/installer/util/package_properties_unittest.cc ('k') | chrome/installer/util/product.cc » ('j') | chrome/installer/util/set_reg_value_work_item.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698