Regkey functions return error code instead of bool

chrome/installer/util/set_reg_value_work_item.h

Index: chrome/installer/util/set_reg_value_work_item.h
===================================================================
--- chrome/installer/util/set_reg_value_work_item.h	(revision 71345)
+++ chrome/installer/util/set_reg_value_work_item.h	(working copy)
@@ -66,23 +66,16 @@
   // Name of the value to be set.
   std::wstring value_name_;
 
-  // Data of the value to be set.
-  std::wstring value_data_str_;  // if data is of type REG_SZ
-  DWORD value_data_dword_;  // if data is of type REG_DWORD
-  int64 value_data_qword_;  // if data is of type REG_QWORD
-
   // Whether to overwrite the existing value under the target key.
   bool overwrite_;
 
   // Type of data to store
   DWORD type_;
+  std::string value_;

[grt (UTC plus 2), 2011/01/14 15:53:43]

My objection to using std::string where std::vector<uint8> belongs applies here
as well.

+  DWORD previous_type_;
+  std::string previous_value_;

[grt (UTC plus 2), 2011/01/14 15:53:43]

And here.

 
   SettingStatus status_;
-
-  // Data of the previous value.
-  std::wstring previous_value_str_;  // if data is of type REG_SZ
-  DWORD previous_value_dword_;  // if data is of type REG_DWORD
-  int64 previous_value_qword_;  // if data is of type REG_QWORD
 };
 
 #endif  // CHROME_INSTALLER_UTIL_SET_REG_VALUE_WORK_ITEM_H__