Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: chrome/installer/setup/chrome_frame_ready_mode.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/chrome_frame_ready_mode.cc
===================================================================
--- chrome/installer/setup/chrome_frame_ready_mode.cc (revision 71345)
+++ chrome/installer/setup/chrome_frame_ready_mode.cc (working copy)
@@ -82,20 +82,18 @@
// Add a work item to delete the ChromeFrameReadyMode registry value.
HKEY root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
item_list->AddDeleteRegValueWorkItem(root, package_properties.GetStateKey(),
- kChromeFrameReadyModeField, REG_QWORD);
+ kChromeFrameReadyModeField);
// Delete the command elevation registry keys
std::wstring version_key(cf->GetVersionKey());
item_list->AddDeleteRegValueWorkItem(
- root, version_key, google_update::kRegCFTempOptOutCmdField, REG_SZ);
+ root, version_key, google_update::kRegCFTempOptOutCmdField);
item_list->AddDeleteRegValueWorkItem(
- root, version_key, google_update::kRegCFEndTempOptOutCmdField, REG_SZ);
+ root, version_key, google_update::kRegCFEndTempOptOutCmdField);
item_list->AddDeleteRegValueWorkItem(root, version_key,
- google_update::kRegCFOptOutCmdField,
- REG_SZ);
+ google_update::kRegCFOptOutCmdField);
item_list->AddDeleteRegValueWorkItem(root, version_key,
- google_update::kRegCFOptInCmdField,
- REG_SZ);
+ google_update::kRegCFOptInCmdField);
if (!item_list->Do()) {
LOG(ERROR) << "Failed to opt into GCF";
@@ -140,8 +138,7 @@
while (values.Valid()) {
const wchar_t* name = values.Name();
if (StartsWith(name, kChromeFramePrefix, true)) {
- item_list->AddDeleteRegValueWorkItem(root, kPostPlatformUAKey, name,
- REG_SZ);
+ item_list->AddDeleteRegValueWorkItem(root, kPostPlatformUAKey, name);
}
++values;
}

Powered by Google App Engine
This is Rietveld 408576698