Regkey functions return error code instead of bool

chrome/installer/util/delete_reg_value_work_item.h

Index: chrome/installer/util/delete_reg_value_work_item.h
===================================================================
--- chrome/installer/util/delete_reg_value_work_item.h	(revision 71345)
+++ chrome/installer/util/delete_reg_value_work_item.h	(working copy)
@@ -40,7 +40,7 @@
   };
 
   DeleteRegValueWorkItem(HKEY predefined_root, const std::wstring& key_path,
-                         const std::wstring& value_name, DWORD type);
+                         const std::wstring& value_name);
 
   // Root key of the target key under which the value is set. The root key can
   // only be one of the predefined keys on Windows.
@@ -52,19 +52,11 @@
   // Name of the value to be set.
   std::wstring value_name_;
 
-  // DWORD that tells whether data value is of type REG_SZ, REG_DWORD, or
-  // REG_QWORD
-  // Ideally we do not need this information from user of this class and can
-  // check the registry for the type. But to simpify implementation we are
-  // going to put the burden on the caller for now to provide us the type.
-  DWORD type_;
-
   DeletionStatus status_;
 
-  // Data of the previous value.
-  std::wstring old_str_;  // if data is of type REG_SZ
-  DWORD old_dw_;  // if data is of type REG_DWORD
-  int64 old_qword_;  // if data is of type REG_QWORD
+  // Previous value.
+  DWORD previous_type_;
+  std::string previous_value_;

[grt (UTC plus 2), 2011/01/14 15:53:43]

It looks like you're using a std::string as a bucket of bytes.  Why not use an
actual bucket of bytes (std::vector<uint8>)?

[amit, 2011/01/15 01:28:11]

Yep, back to vector :)
I started with std::vector then thought using WriteInto would be cool with
std::string so switched to it. Now discovered that WriteInto is not going to
work for non-strings.

 };
 
 #endif  // CHROME_INSTALLER_UTIL_DELETE_REG_VALUE_WORK_ITEM_H_