Issue 6086004: Set Browser::app_name_ in a reasonable way for extension apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6086004: Set Browser::app_name_ in a reasonable way for extension apps. (Closed)

Created:
10 years ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Set Browser::app_name_ in a reasonable way for extension apps. BUG=67702 TEST=BrowserTest.OpenAppWindowLikeNtp,BrowserTest.AppIdSwitch,manually open a few apps and see that windows taskbar hilights the right window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71442

Patch Set 1 #

Patch Set 2 : Revert logging to understand try fails. #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -23 lines)			Patch
M	chrome/browser/browser_browsertest.cc	View		3 chunks	+44 lines, -1 line	0 comments	Download
M	chrome/browser/shell_integration.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/shell_integration_win.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_init.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/web_applications/web_app.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/web_applications/web_app.cc	View	1	7 chunks	+50 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Kerner (Chrome)

Aaron, This change fixes a bug in app shortcuts, so it is a candidate for ...

9 years, 11 months ago (2011-01-11 13:35:38 UTC) #3

lgtm

Expand Messages | Collapse Messages