Set Browser::app_name_ in a reasonable way for extension apps.

chrome/browser/web_applications/web_app.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_applications/web_app.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <shlobj.h>
 #endif  // defined(OS_WIN)
@@ skipping 11 matching lines @@
 #include "base/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_plugin_util.h"
+#include "chrome/common/extensions/extension.h"
 #include "chrome/common/notification_registrar.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/common/web_apps.h"
 
 #if defined(OS_LINUX)
 #include "base/environment.h"
 #endif  // defined(OS_LINUX)
 
 #if defined(OS_WIN)
 #include "base/win_util.h"
@@ skipping 41 matching lines @@
       c = '_';
 
     file_name += c;
   }
 
   return FilePath(file_name);
 }
 #endif  // defined(OS_WIN)
 
 // Returns relative directory of given web app url.
-FilePath GetWebAppDir(const GURL& url) {
-  FilePath::StringType host;
-  FilePath::StringType scheme_port;
+FilePath GetWebAppDir(const ShellIntegration::ShortcutInfo& info) {
+  if (!info.extension_id.empty()) {
+    std::string app_name = web_app::GenerateApplicationNameFromExtensionId(
+        UTF16ToUTF8(info.extension_id));
+#if defined(OS_WIN)
+    return FilePath(UTF8ToWide(app_name));
+#elif defined(OS_POSIX)
+    return FilePath(app_name);
+#endif
+  } else {
+    FilePath::StringType host;
+    FilePath::StringType scheme_port;
 
 #if defined(OS_WIN)
-  host = UTF8ToWide(url.host());
-  scheme_port = (url.has_scheme() ? UTF8ToWide(url.scheme()) : L"http") +
-      FILE_PATH_LITERAL("_") +
-      (url.has_port() ? UTF8ToWide(url.port()) : L"80");
+    host = UTF8ToWide(info.url.host());
+    scheme_port = (info.url.has_scheme() ? UTF8ToWide(info.url.scheme())
+        : L"http") + FILE_PATH_LITERAL("_") +
+        (info.url.has_port() ? UTF8ToWide(info.url.port()) : L"80");
 #elif defined(OS_POSIX)
-  host = url.host();
-  scheme_port = url.scheme() + FILE_PATH_LITERAL("_") + url.port();
+    host = info.url.host();
+    scheme_port = info.url.scheme() + FILE_PATH_LITERAL("_") + info.url.port();
 #endif
 
-  return FilePath(host).Append(scheme_port);
+    return FilePath(host).Append(scheme_port);
+  }
 }
 
 // Returns data directory for given web app url
 FilePath GetWebAppDataDirectory(const FilePath& root_dir,
-                                const GURL& url) {
-  return root_dir.Append(GetWebAppDir(url));
+                                const ShellIntegration::ShortcutInfo& info) {
+  return root_dir.Append(GetWebAppDir(info));
 }
 
 #if defined(TOOLKIT_VIEWS)
 // Predicator for sorting images from largest to smallest.
 bool IconPrecedes(const WebApplicationInfo::IconInfo& left,
                   const WebApplicationInfo::IconInfo& right) {
   return left.width < right.width;
 }
 #endif
 
@@ skipping 111 matching lines @@
   web_app::CreateShortcutCallback* callback_;
   MessageLoop* message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(CreateShortcutTask);
 };
 
 CreateShortcutTask::CreateShortcutTask(
     const FilePath& profile_path,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     web_app::CreateShortcutCallback* callback)
-    : web_app_path_(GetWebAppDataDirectory(web_app::GetDataDir(profile_path),
-                                           shortcut_info.url)),
+    : web_app_path_(GetWebAppDataDirectory(
+        web_app::GetDataDir(profile_path),
+        shortcut_info)),
       profile_path_(profile_path),
       shortcut_info_(shortcut_info),
       callback_(callback),
       message_loop_(MessageLoop::current()) {
   DCHECK(message_loop_ != NULL);
 }
 
 void CreateShortcutTask::Run() {
   bool success = CreateShortcut();
 
@@ skipping 112 matching lines @@
   std::string switches =
      ShellIntegration::GetCommandLineArgumentsCommon(shortcut_info_.url,
      shortcut_info_.extension_id);
   std::wstring wide_switchs(UTF8ToWide(switches));
 
   // Sanitize description
   if (shortcut_info_.description.length() >= MAX_PATH)
     shortcut_info_.description.resize(MAX_PATH - 1);
 
   // Generates app id from web app url and profile path.
+  std::string app_name;
+  if (!shortcut_info_.extension_id.empty()) {
+    app_name = web_app::GenerateApplicationNameFromExtensionId(
+        UTF16ToUTF8(shortcut_info_.extension_id));
+  } else {
+    app_name = web_app::GenerateApplicationNameFromURL(
+        shortcut_info_.url);
+  }
   std::wstring app_id = ShellIntegration::GetAppId(
-      UTF8ToWide(web_app::GenerateApplicationNameFromURL(shortcut_info_.url)),
-      profile_path_);
+      UTF8ToWide(app_name), profile_path_);
 
   FilePath shortcut_to_pin;
 
   bool success = true;
   for (size_t i = 0; i < shortcut_paths.size(); ++i) {
     FilePath shortcut_file = shortcut_paths[i].Append(file_name).
         ReplaceExtension(FILE_PATH_LITERAL(".lnk"));
 
     int unique_number = download_util::GetUniquePathNumber(shortcut_file);
     if (unique_number == -1) {
@@ skipping 216 matching lines @@
 void UpdateShortcutWorker::UpdateShortcuts() {
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       NewRunnableMethod(this,
       &UpdateShortcutWorker::UpdateShortcutsOnFileThread));
 }
 
 void UpdateShortcutWorker::UpdateShortcutsOnFileThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   FilePath web_app_path = GetWebAppDataDirectory(
-      web_app::GetDataDir(profile_path_), shortcut_info_.url);
+      web_app::GetDataDir(profile_path_), shortcut_info_);
 
   // Ensure web_app_path exists. web_app_path could be missing for a legacy
   // shortcut created by gears.
   if (!file_util::PathExists(web_app_path) &&
       !file_util::CreateDirectory(web_app_path)) {
     NOTREACHED();
     return;
   }
 
   FilePath icon_file = web_app_path.Append(file_name_).ReplaceExtension(
@@ skipping 49 matching lines @@
 };  // namespace
 
 #if defined(OS_WIN)
 // Allows UpdateShortcutWorker without adding refcounting. UpdateShortcutWorker
 // manages its own life time and will delete itself when it's done.
 DISABLE_RUNNABLE_METHOD_REFCOUNT(UpdateShortcutWorker);
 #endif  // defined(OS_WIN)
 
 namespace web_app {
 
+// The following string is used to build the directory name for
+// shortcuts to chrome applications (the kind which are installed
+// from a CRX).  Application shortcuts to URLs use the {host}_{path}
+// for the name of this directory.  Hosts can't include an underscore.
+// By starting this string with an underscore, we ensure that there
+// are no naming conflicts.
+static const char* kCrxAppPrefix = "_crx_";
+
 std::string GenerateApplicationNameFromURL(const GURL& url) {
   std::string t;
   t.append(url.host());
   t.append("_");
   t.append(url.path());
   return t;
 }
 
+std::string GenerateApplicationNameFromExtensionId(const std::string& id) {
+  std::string t(web_app::kCrxAppPrefix);
+  t.append(id);
+  return t;
+}
+
 void CreateShortcut(
     const FilePath& data_dir,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     CreateShortcutCallback* callback) {
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       new CreateShortcutTask(data_dir, shortcut_info, callback));
 }
 
 bool IsValidUrl(const GURL& url) {
   static const char* const kValidUrlSchemes[] = {
@@ skipping 51 matching lines @@
 
 void UpdateShortcutForTabContents(TabContents* tab_contents) {
 #if defined(OS_WIN)
   // UpdateShortcutWorker will delete itself when it's done.
   UpdateShortcutWorker* worker = new UpdateShortcutWorker(tab_contents);
   worker->Run();
 #endif  // defined(OS_WIN)
 }
 
 };  // namespace web_app