Issue 6085010: ARM: Fix a bug in the lithium arguments support...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6085010: ARM: Fix a bug in the lithium arguments support... (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (google), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Fix a bug in the lithium arguments support Got the comparison wrong and fortot to actually set the flags. Committed: http://code.google.com/p/v8/source/detail?r=6195

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

http://codereview.chromium.org/6085010/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6085010/diff/1/src/arm/code-stubs-arm.cc#newcode3019 src/arm/code-stubs-arm.cc:3019: __ b(hs, &slow); hs and cs are the same ...

9 years, 11 months ago (2011-01-06 10:12:46 UTC) #1

LGTM

Expand Messages | Collapse Messages