Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 6085010: ARM: Fix a bug in the lithium arguments support... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2998 matching lines...) Expand 10 before | Expand all | Expand 10 after
3009 Label adaptor; 3009 Label adaptor;
3010 __ ldr(r2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset)); 3010 __ ldr(r2, MemOperand(fp, StandardFrameConstants::kCallerFPOffset));
3011 __ ldr(r3, MemOperand(r2, StandardFrameConstants::kContextOffset)); 3011 __ ldr(r3, MemOperand(r2, StandardFrameConstants::kContextOffset));
3012 __ cmp(r3, Operand(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR))); 3012 __ cmp(r3, Operand(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
3013 __ b(eq, &adaptor); 3013 __ b(eq, &adaptor);
3014 3014
3015 // Check index against formal parameters count limit passed in 3015 // Check index against formal parameters count limit passed in
3016 // through register r0. Use unsigned comparison to get negative 3016 // through register r0. Use unsigned comparison to get negative
3017 // check for free. 3017 // check for free.
3018 __ cmp(r1, r0); 3018 __ cmp(r1, r0);
3019 __ b(cs, &slow); 3019 __ b(hs, &slow);
Søren Thygesen Gjesse 2011/01/06 10:12:46 hs and cs are the same - I find hs more readable i
3020 3020
3021 // Read the argument from the stack and return it. 3021 // Read the argument from the stack and return it.
3022 __ sub(r3, r0, r1); 3022 __ sub(r3, r0, r1);
3023 __ add(r3, fp, Operand(r3, LSL, kPointerSizeLog2 - kSmiTagSize)); 3023 __ add(r3, fp, Operand(r3, LSL, kPointerSizeLog2 - kSmiTagSize));
3024 __ ldr(r0, MemOperand(r3, kDisplacement)); 3024 __ ldr(r0, MemOperand(r3, kDisplacement));
3025 __ Jump(lr); 3025 __ Jump(lr);
3026 3026
3027 // Arguments adaptor case: Check index against actual arguments 3027 // Arguments adaptor case: Check index against actual arguments
3028 // limit found in the arguments adaptor frame. Use unsigned 3028 // limit found in the arguments adaptor frame. Use unsigned
3029 // comparison to get negative check for free. 3029 // comparison to get negative check for free.
(...skipping 1950 matching lines...) Expand 10 before | Expand all | Expand 10 after
4980 __ pop(r1); 4980 __ pop(r1);
4981 __ Jump(r2); 4981 __ Jump(r2);
4982 } 4982 }
4983 4983
4984 4984
4985 #undef __ 4985 #undef __
4986 4986
4987 } } // namespace v8::internal 4987 } } // namespace v8::internal
4988 4988
4989 #endif // V8_TARGET_ARCH_ARM 4989 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698